NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-104050: Argument Clinic: Annotate the BufferSeries class#106935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 5 commits intopython:mainfromerlend-aasland:clinic/annotate-buffer-series

Jul 22, 2023

Merged

gh-104050: Argument Clinic: Annotate the BufferSeries class#106935

erlend-aasland merged 5 commits intopython:mainfromerlend-aasland:clinic/annotate-buffer-series

Jul 22, 2023

Conversation

Copy link

Contributor

erlend-aasland commentedJul 20, 2023•
edited by bedevere-bot
Loading

Issue:Add type annotations to clinic.py #104050

erlend-aasland added2 commits

July 21, 2023 00:35

pythongh-104050: Argument Clinic: Annotate BufferSeries

07d41a0

Fix bug in clear() method

1dadf8f

_TextAccumulator has no '_text' attribute; it has 'text'

erlend-aasland requested a review fromAlexWaygood as acode owner

July 20, 2023 22:36

erlend-aasland added the skip news label

Jul 20, 2023

bedevere-bot added the awaiting core review label

Jul 20, 2023

bedevere-bot mentioned this pull request

Jul 20, 2023

Add type annotations to clinic.py#104050

Closed

AlexWaygood reviewed

Jul 20, 2023

View reviewed changes

Tools/clinic/clinic.pyShow resolvedHide resolved

erlend-aasland changed the title~~gh-104050: Argument Clinic: Annotate BufferSeries class~~gh-104050: Argument Clinic: Annotate the BufferSeries class

Jul 20, 2023

serhiy-storchaka approved these changes

Jul 21, 2023

View reviewed changes

Tools/clinic/clinic.py Outdated

Comment on lines 1973 to 1976

		def__getitem__(
		self,
		i:int
		)->_TextAccumulator:

Copy link

Member

serhiy-storchakaJul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Why not write it in one line? It is still pretty short.

Copy link

ContributorAuthor

erlend-aaslandJul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure; I have not yet developed a preference when it comes to annotation style :)

Copy link

Member

AlexWaygoodJul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FWIW, I agree with Serhiy — I would probably put this all on one line — but I also don't really care much either way (life's too short to spend it arguing over code formatting preferences 😄)