Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106905: avoid incorrect SystemError about recursion depth mismatch#106906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 4 commits intopython:mainfrommmohrhard:fix/106864
Nov 13, 2023

Conversation

@mmohrhard
Copy link
Contributor

@mmohrhardmmohrhard commentedJul 20, 2023•
edited by bedevere-bot
Loading

I don't know if this fixes my original problem but it will at least remove one source of incorrect recursion depth mismatch errors.

@mmohrhard
Copy link
ContributorAuthor

Note that in theory this should not be necessary as there is aif (result && state->recursion_depth != starting_recursion_depth) { check but I think there must be an early exit that does not consider a NULL value a problem.

I can only reproduce this issue rarely in a threaded application but let like matching the recursion depth changes is an easy way to make sure that the underlying issue can bubble up instead of hiding behind the recursion depth mismatch error.

@sk1psk1p mentioned this pull requestAug 10, 2023
7 tasks
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsNov 13, 2023
@pablogsalpablogsalenabled auto-merge (squash)November 13, 2023 12:44
@pablogsalpablogsal merged commit1447af7 intopython:mainNov 13, 2023
@miss-islington-app
Copy link

Thanks@mmohrhard for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@mmohrhard and@pablogsal, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 1447af797048e62049d00bbd96d8daee3929f527 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 13, 2023
…smatch (pythonGH-106906)*pythongh-106905: avoid incorrect SystemError about recursion depth mismatch* Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst---------(cherry picked from commit1447af7)Co-authored-by: Markus Mohrhard <markusm@dug.com>Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-112032 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelNov 13, 2023
gpshead pushed a commit to gpshead/cpython that referenced this pull requestDec 7, 2023
…epth mismatch (python#106906)Backport of1447af7 frompython#106906.*pythongh-106905: avoid incorrect SystemError about recursion depth mismatch* Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst---------Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-112849 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelDec 7, 2023
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…smatch (python#106906)*pythongh-106905: avoid incorrect SystemError about recursion depth mismatch* Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst---------Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…smatch (python#106906)*pythongh-106905: avoid incorrect SystemError about recursion depth mismatch* Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst---------Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@isidenticalisidenticalAwaiting requested review from isidentical

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

@pablogsalpablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mmohrhard@serhiy-storchaka@pablogsal@bedevere-bot@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp