Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106789: avoid importing pprint from sysconfig#106790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 6 commits intopython:mainfromiritkatriel:opcode
Jul 17, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJul 15, 2023•
edited by bedevere-bot
Loading

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Too bad about the limerick. Maybe we can ask ChatGPT to write the commit message as a limerick. :-)

Copy link
Member

@FFY00FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

AFAICTrepr for strings should result in (mostly) valid Python code representing the string in question, so I believe this patch is correct. At least, any edge case we could run into withrepr we would likely run into withpprint anyway.

@gvanrossum
Copy link
Member

I don’t think there are any cases where repr() is wrong, are there?

@FFY00
Copy link
Member

FFY00 commentedJul 15, 2023•
edited
Loading

I don't think so either, but I have seen too many edge cases in situations like this, so am not confident saying there aren't any here. I'm fairly confident that this change is okay, though.

iritkatrieland others added2 commitsJuly 16, 2023 11:38
Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@iritkatrieliritkatriel added the stdlibStandard Library Python modules in the Lib/ directory labelJul 16, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@methanemethanemethane approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@FFY00FFY00FFY00 approved these changes

Assignees

No one assigned

Labels

stdlibStandard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sysconfig imports pprint which imports the world

5 participants

@iritkatriel@gvanrossum@FFY00@methane@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp