NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-86493: Fix possible leaks in some modules initialization#106768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:pymodule-add4b

Jul 18, 2023

Merged

gh-86493: Fix possible leaks in some modules initialization#106768

serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:pymodule-add4b

Jul 18, 2023

Conversation

Copy link

Member

serhiy-storchaka commentedJul 15, 2023•
edited
Loading

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.

Use new~~private function_PyModule_AddNew()~~ public functionPyModule_Add() instead ofPyModule_AddObject().

Issue:C API: Add PyModule_Add() function #86493

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12only security fixes labels

Jul 15, 2023

serhiy-storchaka requested a review fromvstinner

July 15, 2023 06:28

serhiy-storchaka requested review frompganssle andabalkin ascode owners

July 15, 2023 06:28

bedevere-bot added the awaiting core review label

Jul 15, 2023

bedevere-bot mentioned this pull request

Jul 15, 2023

C API: Add PyModule_Add() function#86493

Closed

pythongh-86493: Fix possible leaks in some modules initialization

8703a44

Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.

serhiy-storchaka force-pushed thepymodule-add4b branch from1bec79f to8703a44Compare

July 15, 2023 07:21

serhiy-storchaka mentioned this pull request

Jul 17, 2023

bpo-42327: Add PyModule_Add() (smaller).#23443

Merged

serhiy-storchaka added the skip news label

Jul 18, 2023

Merge branch 'main' into pymodule-add4b

63fa1ba

serhiy-storchaka merged commit3e65bae intopython:main

Jul 18, 2023

Copy link

Contributor

miss-islington commentedJul 18, 2023

Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

Jul 18, 2023

serhiy-storchaka deleted the pymodule-add4b branch

July 18, 2023 07:50

Copy link

Contributor

miss-islington commentedJul 18, 2023

Sorry@serhiy-storchaka, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 3e65baee72131b49f4ce8ca2da568a6f2001ce93 3.12

miss-islington assignedserhiy-storchaka

Jul 18, 2023

Copy link

Contributor

miss-islington commentedJul 18, 2023

Sorry,@serhiy-storchaka, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 3e65baee72131b49f4ce8ca2da568a6f2001ce93 3.11

Copy link

Member

vstinner commentedJul 18, 2023

Nice fix. I like when removing characters fix bugs :-D

About the backport: Python 3.11 and 3.12 don't have PyModule_Add(), so you cannot backport these fixes, no? While it's tempting, I don't think that it's worth it.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 18, 2023

[3.12]pythongh-86493: Fix possible leaks in some modules initializat…

e163ec1

…ion (pythonGH-106768)Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time..(cherry picked from commit3e65bae)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Copy link

bedevere-bot commentedJul 18, 2023

GH-106855 is a backport of this pull request to the3.12 branch.

bedevere-bot removed the needs backport to 3.12only security fixes label

Jul 18, 2023

serhiy-storchaka added a commit that referenced this pull request

Jul 18, 2023

[3.12]gh-86493: Fix possible leaks in some modules initialization (G…

a423ddb

…H-106768) (GH-106855)Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.(cherry picked from commit3e65bae)

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 18, 2023

[3.11] [3.12]pythongh-86493: Fix possible leaks in some modules init…

708a1b6

…ialization (pythonGH-106768) (pythonGH-106855)Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.(cherry picked from commit3e65bae).(cherry picked from commita423ddb)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka added a commit that referenced this pull request

Jul 19, 2023

[3.11]gh-86493: Fix possible leaks in some modules initialization (G…

fced79f

…H-106768) (GH-106855) (GH-106863)[3.11] [3.12]gh-86493: Fix possible leaks in some modules initialization (GH-106768) (GH-106855)Fix _ssl, _stat, _testinternalcapi, _threadmodule, cmath, math, posix, time.(cherry picked from commit3e65bae).(cherry picked from commita423ddb)