Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106368: Increase Argument Clinic test coverage#106728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJul 13, 2023•
edited
Loading

  • improve output_parameter() coverage
  • improve coverage for Function.kind

@AlexWaygood
Copy link
Member

I'm probably not the best reviewer for this one, but this all looks reasonable!

erlend-aasland reacted with hooray emoji

@erlend-aasland
Copy link
ContributorAuthor

I'm probably not the best reviewer for this one, but this all looks reasonable!

Thanks! I'll expand this PR so we've got better coverage for your FunctionKind PR.

AlexWaygood reacted with heart emoji

@erlend-aaslanderlend-aasland changed the titlegh-106368: Argument Clinic: Increase coverage for output_parameters()gh-106368: Increase Argument Clinic test coverageJul 13, 2023
@erlend-aasland
Copy link
ContributorAuthor

With this, we're up to approx. 86% test coverage.

AlexWaygood reacted with rocket emoji

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)July 13, 2023 22:17
@erlend-aaslanderlend-aasland merged commitec45c51 intopython:mainJul 13, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker ec45c513d389510930a62631a21a1dbb3f3aabb7 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 13, 2023
)- improve output_parameter() coverage- improve coverage for Function.kind(cherry picked from commitec45c51)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106730 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 13, 2023
@erlend-aaslanderlend-aasland deleted the clinic/coverage-defining-class-alt branchJuly 13, 2023 22:19
@bedevere-bot
Copy link

GH-106731 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 13, 2023
erlend-aasland added a commit that referenced this pull requestJul 13, 2023
…106730)- improve output_parameter() coverage- improve coverage for Function.kind(cherry picked from commitec45c51)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

This comment was marked as off-topic.

erlend-aasland added a commit that referenced this pull requestJul 13, 2023
…106731)- improve output_parameter() coverage- improve coverage for Function.kind(cherry picked from commitec45c51)Co-authored-by: Erlend E. Aasland <erlend@python.org>* Fix merge
@bedevere-bot

This comment was marked as off-topic.

kgdiem pushed a commit to kgdiem/cpython that referenced this pull requestJul 14, 2023
- improve output_parameter() coverage- improve coverage for Function.kind
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees

@erlend-aaslanderlend-aasland

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@AlexWaygood@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp