Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105481: expose opcode metadata via the _opcode module#106688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 10 commits intopython:mainfromiritkatriel:expose_metadata
Jul 14, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJul 12, 2023•
edited by bedevere-bot
Loading

@iritkatriel
Copy link
MemberAuthor

There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow.

@iritkatrieliritkatriel marked this pull request as ready for reviewJuly 14, 2023 14:39
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!

@iritkatriel
Copy link
MemberAuthor

Yes, I didn't want to expose the bitmap implementation.

gvanrossum reacted with thumbs up emoji

@iritkatrieliritkatriel merged commit6a70edf intopython:mainJul 14, 2023
@iritkatrieliritkatriel deleted the expose_metadata branchJuly 25, 2023 18:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@iritkatriel@gvanrossum@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp