Movatterモバイル変換

serhiy-storchaka requested a review fromvstinner

serhiy-storchaka requested review fromrhettinger,berkerpeksag,erlend-aasland,isidentical,pganssle,abalkin,brettcannon,ericsnowcurrently,ncoghlan,warsaw,iritkatriel,markshannon,methane,1st1,asvetlov,gvanrossum,kumaraditya303 andwillingc ascode owners

bedevere-bot added the awaiting core review label

bedevere-bot mentioned this pull request

C API: Add PyObject_GetOptionalAttr() function#106521

Closed

serhiy-storchaka removed request forberkerpeksag,brettcannon,methane,warsaw,1st1,asvetlov andncoghlan

serhiy-storchaka removed request foriritkatriel,ericsnowcurrently,pganssle,rhettinger,willingc,gvanrossum,markshannon,erlend-aasland,isidentical,kumaraditya303 andabalkin

carljm approved these changes

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

erlend-aasland approved these changes

View reviewed changes

vstinner approved these changes

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

You may change the change title to "Remove _PyObject_LookupAttr() function". In practice (in terms of C API), this change removes the function, since the previous changeadded a new function. I'm fine with removing private functions, but it seems like@encukou started to have concerns about such removals in Python 3.13 C API: see#106320

serhiy-storchaka changed the title~~gh-106521: Replace _PyObject_LookupAttr with PyObject_GetOptionalAttr in code~~gh-106521: Remove _PyObject_LookupAttr() function

serhiy-storchaka merged commitbe1b968 intopython:main

bedevere-bot removed the awaiting merge label