Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE#106599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gvanrossum left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, this should work withgh-106551 once that's ready.
gvanrossum commentedJul 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for |
gvanrossum commentedJul 10, 2023
I pushed merge (since the conflict was my fault) but I'll leave it to you to land. |
Uh oh!
There was an error while loading.Please reload this page.
Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.