NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-106521: Add PyObject_GetOptionalAttr() function#106522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 11 commits intopython:mainfromserhiy-storchaka:PyObject_GetOptionalAttr

Jul 11, 2023

Merged

gh-106521: Add PyObject_GetOptionalAttr() function#106522

serhiy-storchaka merged 11 commits intopython:mainfromserhiy-storchaka:PyObject_GetOptionalAttr

Jul 11, 2023

Conversation

Copy link

Member

serhiy-storchaka commentedJul 7, 2023•
edited by github-actionsbot
Loading

It is a new name of former _PyObject_LookupAttr().

Issue:C API: Add PyObject_GetOptionalAttr() function #106521

📚 Documentation preview 📚:https://cpython-previews--106522.org.readthedocs.build/

pythongh-106521: Add PyObject_GetOptionalAttr() function

cf4d3cd

It is a new name of former _PyObject_LookupAttr().

serhiy-storchaka requested review fromrhettinger,berkerpeksag,erlend-aasland,isidentical,pganssle,abalkin,brettcannon,ericsnowcurrently,ncoghlan,warsaw,iritkatriel,markshannon,methane,1st1,asvetlov,gvanrossum,kumaraditya303 andwillingc ascode owners

July 7, 2023 16:15

bedevere-bot added the awaiting core review label

Jul 7, 2023

bedevere-bot mentioned this pull request

Jul 7, 2023

C API: Add PyObject_GetOptionalAttr() function#106521

Closed

Update Misc/stable_abi.toml.

3fb9775

serhiy-storchaka requested review froma team andencukou ascode owners

July 7, 2023 18:33

carljm reviewed

Jul 7, 2023

View reviewed changes

Doc/c-api/object.rst OutdatedShow resolvedHide resolved

Doc/whatsnew/3.13.rst OutdatedShow resolvedHide resolved

Include/abstract.h OutdatedShow resolvedHide resolved

brettcannon removed request fora team,brettcannon,erlend-aasland,isidentical andkumaraditya303

July 7, 2023 22:01

serhiy-storchaka requested review fromvstinner and removed request forberkerpeksag,pganssle,abalkin,ericsnowcurrently,ncoghlan,warsaw,iritkatriel,markshannon,methane,1st1,asvetlov,gvanrossum,willingc andencukou

July 10, 2023 12:59

vstinner reviewed

Jul 10, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To ease the review, you might keep the old name with an alias#define _PyObject_LookupAttr PyObject_GetOptionalAttr, and then write a second PR to update usage of the old name. (Well, just split the PR in two parts.)

Doc/c-api/object.rst



		.. c:function:: int PyObject_GetOptionalAttrString(PyObject obj, const char attr_name, PyObject **result);

Copy link

Member

vstinnerJul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You may just say:

Similar to :c:func:`PyObject_GetOptionalAttr`, but *name* is a UTF-8 encoded string.

To not copy/paste the documentation.

Copy link

MemberAuthor

serhiy-storchakaJul 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In all other functions withString suffix the documentation is repeated. If we are going to change this, it should be changed for all function at once.

Doc/c-api/object.rst OutdatedShow resolvedHide resolved

Doc/whatsnew/3.13.rst OutdatedShow resolvedHide resolved

serhiy-storchakaand others added3 commits

July 11, 2023 10:34

Apply suggestions from code review

be344ce

Co-authored-by: Victor Stinner <vstinner@python.org>

Update other documentation according to review.

0f286c0

Minimize changes.

2343773

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 11, 2023

Rewrite documentation according to review inpython#106522.

d6a9204

vstinner approved these changes

Jul 11, 2023

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for the update.

bedevere-bot added awaiting merge and removed awaiting core review labels

Jul 11, 2023

Copy link

MemberAuthor

serhiy-storchaka commentedJul 11, 2023

Thank you for review@carljm and@vstinner, and especially for your documentation suggestions.

Merge branch 'main' into PyObject_GetOptionalAttr

e9ffff1

serhiy-storchaka merged commit579aa89 intopython:main

Jul 11, 2023

bedevere-bot removed the awaiting merge label

Jul 11, 2023

serhiy-storchaka deleted the PyObject_GetOptionalAttr branch

July 11, 2023 19:13

cdce8p mentioned this pull request

Jul 7, 2024

Fix_PyObject_LookupAttrId for Python 3.13python/mypy#17505

Merged

hauntsaninja pushed a commit to python/mypy that referenced this pull request

Jul 7, 2024

Fix_PyObject_LookupAttrIdfor Python 3.13 (#17505)

7f67090

`_PyObject_LookupAttrId` was removed / replaced with`PyObject_GetOptionalAttrString` inpython/cpython#106522.https://docs.python.org/dev/c-api/object.html#c.PyObject_GetOptionalAttrStringFixes```cpp  /home/runner/work/mypy/mypy/mypyc/lib-rt/pythonsupport.h: In function ‘update_bases’: (diff)  /home/runner/work/mypy/mypy/mypyc/lib-rt/pythonsupport.h:51:13: error: implicit declaration of function ‘_PyObject_LookupAttrId’; did you mean ‘_PyObject_GetAttrId’? [-Werror=implicit-function-declaration] (diff)     51 |         if (_PyObject_LookupAttrId(base, &PyId___mro_entries__, &meth) < 0) { (diff)        |             ^~~~~~~~~~~~~~~~~~~~~~ (diff)        |             _PyObject_GetAttrId (diff)```

Labels

None yet

4 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-106521: Add PyObject_GetOptionalAttr() function#106522

gh-106521: Add PyObject_GetOptionalAttr() function#106522

Uh oh!

Conversation

serhiy-storchaka commentedJul 7, 2023•
edited by github-actionsbot
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinnerJul 10, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaJul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commentedJul 11, 2023

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

gh-106521: Add PyObject_GetOptionalAttr() function#106522

gh-106521: Add PyObject_GetOptionalAttr() function#106522

Uh oh!

Conversation

serhiy-storchaka commentedJul 7, 2023• edited by github-actionsbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinnerJul 10, 2023

Choose a reason for hiding this comment

Uh oh!

serhiy-storchakaJul 11, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka commentedJul 11, 2023

Uh oh!

Uh oh!

serhiy-storchaka commentedJul 7, 2023•
edited by github-actionsbot
Loading