NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-105497: [Enum] Fix flag mask inversion when unnamed flags exist#106468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ambv merged 2 commits intopython:mainfromethanfurman:enum-invert

Jul 11, 2023

Merged

gh-105497: [Enum] Fix flag mask inversion when unnamed flags exist#106468

ambv merged 2 commits intopython:mainfromethanfurman:enum-invert

Jul 11, 2023

Conversation

Copy link

Member

ethanfurman commentedJul 5, 2023•
edited by bedevere-bot
Loading

For example:

class Flag(enum.Flag):    A = 0x01    B = 0x02    MASK = 0xff~Flag.MASK is Flag(0)

This restores 3.10 behavior:

~Flag.A = <Flag.B: 2>(~Flag.A).value = 2~Flag.A is Flag.B = True~Flag.A == Flag.B = True~Flag.Mask = <Flag.0: 0>(~Flag.Mask).value = 0~Flag.Mask is Flag(0) = True~Flag.Mask == Flag(0) = True

Issue:3.11.4: ValueError when inverting enum.Flag member with mask member #105497

Fix flag mask inversion when unnamed flags exist.

a6beb03

For example:    class Flag(enum.Flag):        A = 0x01        B = 0x02        MASK = 0xff    ~Flag.MASK is Flag(0)

ethanfurman added type-bug

An unexpected behavior, bug, or error

stdlib

Standard Library Python modules in the Lib/ directory

3.11

only security fixes

3.12

only security fixes

needs backport to 3.11

only security fixes

3.13

bugs and security fixes

needs backport to 3.12only security fixes labels

Jul 5, 2023

ethanfurman self-assigned this

Jul 5, 2023

bedevere-bot added the awaiting core review label

Jul 5, 2023

bedevere-bot mentioned this pull request

Jul 5, 2023

3.11.4: ValueError when inverting enum.Flag member with mask member#105497

Closed

ethanfurman requested review fromambv andhugovk

July 5, 2023 21:45

EJECT and KEEP flags (IntEnum is KEEP) use direct value.

758de5f

Copy link

MemberAuthor

ethanfurman commentedJul 5, 2023

That last commit should sayIntFlag is KEEP --Enum s don't have boundaries.

ambv merged commit95b7426 intopython:main

Jul 11, 2023

Copy link

Contributor

miss-islington commentedJul 11, 2023

Thanks@ethanfurman for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot removed the awaiting core review label

Jul 11, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 11, 2023

pythongh-105497: [Enum] Fix flag mask inversion when unnamed flags ex…

99ca7d8

…ist (pythonGH-106468)For example:    class Flag(enum.Flag):        A = 0x01        B = 0x02        MASK = 0xff    ~Flag.MASK is Flag(0)(cherry picked from commit95b7426)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

Copy link

bedevere-bot commentedJul 11, 2023

GH-106620 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 11, 2023

pythongh-105497: [Enum] Fix flag mask inversion when unnamed flags ex…

784be81

…ist (pythonGH-106468)For example:    class Flag(enum.Flag):        A = 0x01        B = 0x02        MASK = 0xff    ~Flag.MASK is Flag(0)(cherry picked from commit95b7426)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

bedevere-bot removed the needs backport to 3.12only security fixes label

Jul 11, 2023

Copy link

bedevere-bot commentedJul 11, 2023

GH-106621 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Jul 11, 2023

Yhg1s pushed a commit that referenced this pull request

Jul 11, 2023

[3.12]gh-105497: [Enum] Fix flag mask inversion when unnamed flags e…

6968f9e

…xist (GH-106468) (#106620)gh-105497: [Enum] Fix flag mask inversion when unnamed flags exist (GH-106468)For example:    class Flag(enum.Flag):        A = 0x01        B = 0x02        MASK = 0xff    ~Flag.MASK is Flag(0)(cherry picked from commit95b7426)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

Yhg1s pushed a commit that referenced this pull request

Jul 11, 2023

[3.11]gh-105497: [Enum] Fix flag mask inversion when unnamed flags e…

318f6ae

…xist (GH-106468) (#106621)gh-105497: [Enum] Fix flag mask inversion when unnamed flags exist (GH-106468)For example:    class Flag(enum.Flag):        A = 0x01        B = 0x02        MASK = 0xff    ~Flag.MASK is Flag(0)(cherry picked from commit95b7426)Co-authored-by: Ethan Furman <ethan@stoneleaf.us>

ethanfurman deleted the enum-invert branch

February 1, 2024 01:26