Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96844: Improve error message of list.remove#106455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 3 commits intopython:mainfromcorona10:gh-96844
Jul 5, 2023

Conversation

corona10
Copy link
Member

@corona10corona10 commentedJul 5, 2023•
edited by github-actionsbot
Loading

@corona10
Copy link
MemberAuthor

corona10 commentedJul 5, 2023•
edited
Loading

Concern about large input ->#96844 (comment)
: It was already used for list.index method so that it will not be a issue

>>> a = []>>> a.index(42)Traceback (most recent call last):  File "<stdin>", line 1, in <module>ValueError: 42 is not in list

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I agree with the rationale on error message length in the issue. Maybe we can limit the error message length, but that's out of the scope of this minor change.

@corona10corona10 merged commit217f47d intopython:mainJul 5, 2023
@corona10corona10 deleted the gh-96844 branchJuly 5, 2023 22:19
vstinner pushed a commit to vstinner/cpython that referenced this pull requestMar 18, 2024
vstinner added a commit to vstinner/cpython that referenced this pull requestMar 18, 2024
vstinner added a commit to vstinner/cpython that referenced this pull requestMar 18, 2024
vstinner added a commit to vstinner/cpython that referenced this pull requestMar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aasland

@AlexWaygoodAlexWaygoodAwaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@corona10@vstinner@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp