Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clarify state of CancelledError in doc#106453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@kristjanvalur
Copy link
Contributor

@kristjanvalurkristjanvalur commentedJul 5, 2023
edited by github-actionsbot
Loading

This change makes it explicit thatasyncio.CancelledErroris not a subclass ofException.
The previous wording technically allowed for the interpretation that itmight also be anException, and that this were therefore somehow interpretation-defined. This change corresponds to the text in the "What's new in 3.8" section.


📚 Documentation preview 📚:https://cpython-previews--106453.org.readthedocs.build/

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nitpicky, but sure.

kristjanvalur reacted with thumbs up emoji
@miss-islington
Copy link
Contributor

Thanks@kristjanvalur for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@kristjanvalur for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@kristjanvalur and@gvanrossum, I had trouble checking out the3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 12a98138083589314d3da14bc97f2d8517947437 3.11

@bedevere-bot
Copy link

GH-106454 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 5, 2023
@AlexWaygoodAlexWaygood added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsJul 5, 2023
@miss-islington
Copy link
Contributor

Thanks@kristjanvalur for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106456 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 5, 2023
This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.(cherry picked from commit12a9813)Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull requestJul 5, 2023
* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)  Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)  tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)  Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)  ...
gvanrossum pushed a commit that referenced this pull requestJul 5, 2023
Clarify state of CancelledError in doc (GH-106453)This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.(cherry picked from commit12a9813)Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
@kristjanvalurkristjanvalur deleted the kristjan/doc-cancellederror branchJuly 6, 2023 09:00
kumaraditya303 pushed a commit that referenced this pull requestJul 6, 2023
Clarify state of CancelledError in doc (GH-106453)This change makes it explicit that asyncio.CancelledError is not a subclass of Exception.(cherry picked from commit12a9813)Co-authored-by: Kristján Valur Jónsson <sweskman@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@gvanrossumgvanrossum

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kristjanvalur@miss-islington@bedevere-bot@gvanrossum@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp