Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-106360: Support very basic superblock introspection#106422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedJul 4, 2023
edited
Loading

Adds indexing andlen() support to uop superblocks, such that this:

deftestfunc(x):i=0whilei<x:i+=1testfunc(100)foroffsetinrange(0,100,2):try:ex=_testinternalcapi.get_executor(testfunc.__code__,offset)breakexceptValueError:passforuopinex:print(uop)

produces this

('SAVE_IP', 7)('LOAD_FAST', 1)('SAVE_IP', 8)('LOAD_CONST', 2)('SAVE_IP', 9)('_GUARD_BOTH_INT', 13)('_BINARY_OP_ADD_INT', 13)('SAVE_IP', 11)('STORE_FAST', 1)('SAVE_IP', 12)('LOAD_FAST', 1)('LOAD_FAST', 0)('SAVE_IP', 13)('COMPARE_OP_INT', 18)('SAVE_IP', 15)

@markshannon
Copy link
MemberAuthor

This PR also adds_PyOpcode_OpName and_PyOpcode_uop_name to non-debug builds because they are only a few Kbs of static data, and it is nice to be able to introspect things.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This just needs a merge.

In the light of rising concerns over symbols starting with_Py still being public, maybe we should rename these or move the header file? These tables should be allowed to change on a whim.

pass
if ex is None:
return
self.assertIn("SET_IP", str(ex))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think once you merge main you'll see that this is now calledSAVE_IP.

markshannon reacted with thumbs up emoji
@markshannon
Copy link
MemberAuthor

markshannon commentedJul 4, 2023
edited
Loading

In the light of rising concerns over symbols starting with _Py still being public.

They aren't public though. We strip_Py symbols from the binary, unless they are marked with aPyAPI_FUNC orPyAPI_DATA macro.

gvanrossum reacted with thumbs up emoji

@markshannonmarkshannon merged commit318ea2c intopython:mainJul 4, 2023
carljm added a commit to carljm/cpython that referenced this pull requestJul 5, 2023
* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)  Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)  tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)  Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)  ...
@markshannonmarkshannon deleted the superblock-introspection branchAugust 6, 2024 10:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@markshannon@gvanrossum@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp