Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-106368: Add tests for formatting helpers in Argument Clinic#106415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Added new test class FormatHelperTests()
erlend-aasland commentedJul 4, 2023
|
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few thoughts:
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
- Be explicit- Ditch trivial test
AlexWaygood left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Thanks!
miss-islington commentedJul 4, 2023
Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ythonGH-106415)(cherry picked from commit2fb9480)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot commentedJul 4, 2023
GH-106438 is a backport of this pull request to the3.12 branch. |
…ythonGH-106415)(cherry picked from commit2fb9480)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot commentedJul 4, 2023
GH-106439 is a backport of this pull request to the3.11 branch. |
…GH-106415) (#106438)gh-106368: Add tests for formatting helpers in Argument Clinic (GH-106415)(cherry picked from commit2fb9480)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433) Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443) tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434) Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367) ...
Uh oh!
There was an error while loading.Please reload this page.
Added new test class FormatHelperTests()