NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-61215: Rename`wait_until_any_call` to`wait_until_any_call_with`#106414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cjw296 merged 1 commit intopython:mainfrommariocj89:pu/wait-with

Jul 4, 2023

Merged

gh-61215: Rename`wait_until_any_call` to`wait_until_any_call_with`#106414

cjw296 merged 1 commit intopython:mainfrommariocj89:pu/wait-with

Jul 4, 2023

Conversation

Copy link

Contributor

mariocj89 commentedJul 4, 2023•
edited by github-actionsbot
Loading

Rename the method to be more explicit that it expects the args and kwargs to wait for.

Issue:Allow waiting on a mock #61215

📚 Documentation preview 📚:https://cpython-previews--106414.org.readthedocs.build/

mock: Renamewait_until_any_call towait_until_any_call_with

dd74753

Rename the method to be more explicit that it expects the args andkwargs to wait for.

mariocj89 requested a review fromcjw296 as acode owner

July 4, 2023 12:18

bedevere-bot added the awaiting review label

Jul 4, 2023

bedevere-bot mentioned this pull request

Jul 4, 2023

Allow waiting on a mock#61215

Closed

mariocj89 mentioned this pull request

Jul 4, 2023

gh-61215: New mock to wait for multi-threaded events to happen#16094

Merged

Copy link

ContributorAuthor

mariocj89 commentedJul 4, 2023

Per the comment in#16094 (comment).

This does not need a news entry.

tirkarthi added the skip news label

Jul 4, 2023

cjw296 approved these changes

Jul 4, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jul 4, 2023

cjw296 merged commit2dfc7fa intopython:main

Jul 4, 2023

bedevere-bot removed the awaiting merge label

Jul 4, 2023

carljm added a commit to carljm/cpython that referenced this pull request

Jul 5, 2023

Merge branch 'main' into modulelocals

4c59e51

* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)  Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)  tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)  Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)  ...