Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106368: Add tests for permutation helpers in Argument Clinic#106407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJul 4, 2023•
edited by bedevere-bot
Loading

Added new test class PermutationTests()

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! 👍

erlend-aasland reacted with hooray emoji
@erlend-aaslanderlend-aaslandenabled auto-merge (squash)July 4, 2023 11:25
@erlend-aaslanderlend-aasland merged commit8f6df5e intopython:mainJul 4, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 4, 2023
…pythonGH-106407)Added new test class PermutationTests()(cherry picked from commit8f6df5e)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106409 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 4, 2023
…pythonGH-106407)Added new test class PermutationTests()(cherry picked from commit8f6df5e)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 4, 2023
@bedevere-bot
Copy link

GH-106410 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 4, 2023
@erlend-aaslanderlend-aasland deleted the clinic/test-permutators branchJuly 4, 2023 12:16
erlend-aasland added a commit that referenced this pull requestJul 4, 2023
GH-106407) (#106409)Added new test class PermutationTests()(cherry picked from commit8f6df5e)Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull requestJul 4, 2023
GH-106407) (#106410)Added new test class PermutationTests()(cherry picked from commit8f6df5e)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aasland
Copy link
ContributorAuthor

Hm, I should have put these in the existingClinicGroupPermuterTest test case. Let's keep that in mind and merge those two later, when we get the chance.

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Arch Linux TraceRefs 3.x has failed when building commit8f6df5e.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3602) and take a look at the build logs.
  4. Check if the failure is related to this commit (8f6df5e) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3602

Failed tests:

  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 34, done.remote:Counting objects:   2% (1/34)remote:Counting objects:   5% (2/34)remote:Counting objects:   8% (3/34)remote:Counting objects:  11% (4/34)remote:Counting objects:  14% (5/34)remote:Counting objects:  17% (6/34)remote:Counting objects:  20% (7/34)remote:Counting objects:  23% (8/34)remote:Counting objects:  26% (9/34)remote:Counting objects:  29% (10/34)remote:Counting objects:  32% (11/34)remote:Counting objects:  35% (12/34)remote:Counting objects:  38% (13/34)remote:Counting objects:  41% (14/34)remote:Counting objects:  44% (15/34)remote:Counting objects:  47% (16/34)remote:Counting objects:  50% (17/34)remote:Counting objects:  52% (18/34)remote:Counting objects:  55% (19/34)remote:Counting objects:  58% (20/34)remote:Counting objects:  61% (21/34)remote:Counting objects:  64% (22/34)remote:Counting objects:  67% (23/34)remote:Counting objects:  70% (24/34)remote:Counting objects:  73% (25/34)remote:Counting objects:  76% (26/34)remote:Counting objects:  79% (27/34)remote:Counting objects:  82% (28/34)remote:Counting objects:  85% (29/34)remote:Counting objects:  88% (30/34)remote:Counting objects:  91% (31/34)remote:Counting objects:  94% (32/34)remote:Counting objects:  97% (33/34)remote:Counting objects: 100% (34/34)remote:Counting objects: 100% (34/34), done.remote:Compressing objects:   5% (1/17)remote:Compressing objects:  11% (2/17)remote:Compressing objects:  17% (3/17)remote:Compressing objects:  23% (4/17)remote:Compressing objects:  29% (5/17)remote:Compressing objects:  35% (6/17)remote:Compressing objects:  41% (7/17)remote:Compressing objects:  47% (8/17)remote:Compressing objects:  52% (9/17)remote:Compressing objects:  58% (10/17)remote:Compressing objects:  64% (11/17)remote:Compressing objects:  70% (12/17)remote:Compressing objects:  76% (13/17)remote:Compressing objects:  82% (14/17)remote:Compressing objects:  88% (15/17)remote:Compressing objects:  94% (16/17)remote:Compressing objects: 100% (17/17)remote:Compressing objects: 100% (17/17), done.remote:Total 20 (delta 16), reused 6 (delta 3), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '8f6df5e9cbc3a1689601714192aa6ecbb23e1927'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 8f6df5e9cb gh-106368: Add tests for permutation helpers in Argument Clinic (#106407)Switched to and reset branch 'main'Objects/object.c:2197: _Py_ForgetReference: Assertion failed: invalid object chainEnable tracemalloc to get the memory block allocation tracebackobject address  : 0x7fc2dd670ee0object refcount : 0object type     : 0x55b810834bc0object type name: strobject repr     : <refcnt 0 at 0x7fc2dd670ee0>Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailedPython runtime state: initializedCurrent thread 0x00007fc2ef2de740 (most recent call first):  <no Python frame>Debug memory block at address p=0x7fc2ef205e00: API '�'18302063728033390045bytes originally requested    The7 padbytes at p-7 arenotall FORBIDDENBYTE (0xfd):        at p-7:0xdd***OUCH        at p-6:0xdd***OUCH        at p-5:0xdd***OUCH        at p-4:0xdd***OUCH        at p-3:0xdd***OUCH        at p-2:0xdd***OUCH        at p-1:0xdd***OUCH    Because memoryis corrupted at the start, the count ofbytes requested       may be bogus,and checking the trailing padbytes may segfault.    The8 padbytes at tail=0xfdfe7dc0ed1e3bdd are Fatal Python error: Segmentation faultCurrent thread 0x00007fc2ef2de740 (most recent call first):  <no Python frame>Extension modules: _testcapi, _xxsubinterpreters (total: 2)make:*** [Makefile:2010: buildbottest] Segmentation fault (core dumped)Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL7 LTO 3.11 has failed when building commit9f8aa7a.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/924/builds/913) and take a look at the build logs.
  4. Check if the failure is related to this commit (9f8aa7a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/924/builds/913

Failed tests:

  • test___all__
  • test_tools

Failed subtests:

  • test_freeze_simple_script - test.test_tools.test_freeze.TestFreeze.test_freeze_simple_script
  • test_all - test.test___all__.AllTest.test_all

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

413 tests OK.

10 slowest tests:

  • test_tools: 3 min 39 sec
  • test_concurrent_futures: 2 min 27 sec
  • test_multiprocessing_spawn: 2 min 14 sec
  • test_multiprocessing_forkserver: 1 min 24 sec
  • test_multiprocessing_fork: 1 min 14 sec
  • test_tokenize: 1 min 9 sec
  • test_asyncio: 1 min 4 sec
  • test_peg_generator: 49.5 sec
  • test_signal: 48.1 sec
  • test_unparse: 41.5 sec

1 test failed:
test_tools

20 tests skipped:
test_devpoll test_gdb test_idle test_ioctl test_kqueue
test_launcher test_msilib test_smtpnet test_ssl test_startfile
test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound
test_zipfile64

2 re-run tests:
test___all__ test_tools

Total duration: 9 min 58 sec

Click to see traceback logs
Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line28, intest_freeze_simple_script    executable= helper.freeze(python, scriptfile, outdir)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line198, infreeze    _run_quiet([MAKE,'-C', os.path.dirname(scriptfile)])  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line25, in_run_quietreturn subprocess.run(^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line571, inrunraise CalledProcessError(retcode, process.args,subprocess.CalledProcessError:Command '['/usr/bin/make', '-C', '/tmp/tmpuzyw3yoh']' returned non-zero exit status 2.Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/multiprocessing/resource_tracker.py", line209, inmain    cache[rtype].remove(name)KeyError:'/psm_79b4645b'Traceback (most recent call last):  File"<string>", line1, in<module>  File"/tmp/tmpuzyw3yoh/cpython/Lib/sysconfig.py", line715, inget_config_varreturn get_config_vars().get(name)^^^^^^^^^^^^^^^^^  File"/tmp/tmpuzyw3yoh/cpython/Lib/sysconfig.py", line670, inget_config_vars    _init_posix(_CONFIG_VARS)  File"/tmp/tmpuzyw3yoh/cpython/Lib/sysconfig.py", line531, in_init_posix    _temp=__import__(name,globals(),locals(), ['build_time_vars'],0)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ModuleNotFoundError:No module named '_sysconfigdata__linux_s390x-linux-gnu'Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/test_tools/test_freeze.py", line28, intest_freeze_simple_script    executable= helper.freeze(python, scriptfile, outdir)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line198, infreeze    _run_quiet([MAKE,'-C', os.path.dirname(scriptfile)])  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Tools/freeze/test/freeze.py", line25, in_run_quietreturn subprocess.run(^^^^^^^^^^^^^^^  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/subprocess.py", line571, inrunraise CalledProcessError(retcode, process.args,subprocess.CalledProcessError:Command '['/usr/bin/make', '-C', '/tmp/tmp4po6o4wf']' returned non-zero exit status 2.Traceback (most recent call last):  File"<string>", line1, in<module>  File"/tmp/tmp4po6o4wf/cpython/Lib/sysconfig.py", line715, inget_config_varreturn get_config_vars().get(name)^^^^^^^^^^^^^^^^^  File"/tmp/tmp4po6o4wf/cpython/Lib/sysconfig.py", line670, inget_config_vars    _init_posix(_CONFIG_VARS)  File"/tmp/tmp4po6o4wf/cpython/Lib/sysconfig.py", line531, in_init_posix    _temp=__import__(name,globals(),locals(), ['build_time_vars'],0)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ModuleNotFoundError:No module named '_sysconfigdata__linux_s390x-linux-gnu'Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/test___all__.py", line129, intest_allself.check_all(modname)  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/test___all__.py", line43, incheck_allwith warnings_helper.check_warnings(  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/contextlib.py", line144, in__exit__next(self.gen)  File"/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/support/warnings_helper.py", line185, in_filterwarningsraiseAssertionError("unhandled warning%s"% reraise[0])AssertionError:unhandled warning {message : DeprecationWarning("invalid escape sequence '\\?'"), category : 'DeprecationWarning', filename : '/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z.lto/build/Lib/test/test_httpservers.py', lineno : 445, line : None}

carljm added a commit to carljm/cpython that referenced this pull requestJul 5, 2023
* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)  Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)  tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)  Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@miss-islington@bedevere-bot@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp