NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-106320: Remove private _PyImport C API functions#106383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:pycore_import

Jul 3, 2023

Merged

gh-106320: Remove private _PyImport C API functions#106383

vstinner merged 1 commit intopython:mainfromvstinner:pycore_import

Jul 3, 2023

Conversation

Copy link

Member

vstinner commentedJul 3, 2023•
edited by bedevere-bot
Loading

Remove private _PyImport C API functions: move them to the internal C API (pycore_import.h).
No longer export most of these private functions.
_testcapi avoids private _PyImport_GetModuleAttrString().

Issue:C API: Remove private C API functions (move them to the internal C API) #106320

pythongh-106320: Remove private _PyImport C API functions

6ad5689

* Remove private _PyImport C API functions: move them to the internal  C API (pycore_import.h).* No longer export most of these private functions.* _testcapi avoids private _PyImport_GetModuleAttrString().

vstinner added the skip news label

Jul 3, 2023

vstinner requested review fromcorona10,berkerpeksag,erlend-aasland,brettcannon,ericsnowcurrently,ncoghlan andwarsaw ascode owners

July 3, 2023 22:29

bedevere-bot added the awaiting core review label

Jul 3, 2023

bedevere-bot mentioned this pull request

Jul 3, 2023

C API: Remove private C API functions (move them to the internal C API)#106320

Closed

vstinnerenabled auto-merge (squash)

July 3, 2023 22:53

vstinner merged commit2e92edb intopython:main

Jul 3, 2023

bedevere-bot removed the awaiting core review label

Jul 3, 2023

vstinner deleted the pycore_import branch

July 3, 2023 23:02

carljm added a commit to carljm/cpython that referenced this pull request

Jul 4, 2023

Merge branch 'main' into cachedpropdoublecheck

7a7fd43

* main:pythongh-106368: Increase Argument Clinic test coverage (python#106389)pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)pythongh-106368: Harden Argument Clinic parser tests (python#106384)pythongh-106320: Remove private _PyImport C API functions (python#106383)pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)pythongh-106368: Clean up Argument Clinic tests (python#106373)