Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106368: Clean up Argument Clinic tests#106373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJul 3, 2023•
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

If we're going to increase coverage for Argument Clinic, we need to clean up the test code a little bit; we need readable tests, and we need to be able to debug existing tests without pulling our hair.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for doing this, in my opinion, it is much more readable now.

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)July 3, 2023 21:32
@erlend-aasland
Copy link
ContributorAuthor

Aftergh-106373, we should make thetest_disallowed_* tests more accurate. Most of them simply runself.parse_function_should_fail without checking the error message. This makes it hard to verify that the test is checking the right path.

@erlend-aaslanderlend-aasland merged commit3ee8dac intopython:mainJul 3, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 3ee8dac7a1b3882aa3aac7703bdae2de7b6402ad 3.12

@miss-islington
Copy link
Contributor

Sorry@erlend-aasland, I had trouble checking out the3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 3ee8dac7a1b3882aa3aac7703bdae2de7b6402ad 3.11

@bedevere-bot
Copy link

GH-106379 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJul 3, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJul 3, 2023
(cherry picked from commit3ee8dac)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@erlend-aaslanderlend-aasland deleted the clinic/clean-up-tests branchJuly 3, 2023 22:04
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJul 3, 2023
(cherry picked from commit3ee8dac)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106381 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJul 3, 2023
erlend-aasland added a commit that referenced this pull requestJul 3, 2023
erlend-aasland added a commit that referenced this pull requestJul 3, 2023
carljm added a commit to carljm/cpython that referenced this pull requestJul 4, 2023
* main:pythongh-106368: Increase Argument Clinic test coverage (python#106389)pythongh-106320: Fix _PyImport_GetModuleAttr() declaration (python#106386)pythongh-106368: Harden Argument Clinic parser tests (python#106384)pythongh-106320: Remove private _PyImport C API functions (python#106383)pythongh-86085: Remove _PyCodec_Forget() declaration (python#106377)pythongh-106320: Remove more private _PyUnicode C API functions (python#106382)pythongh-104050: Annotate more Argument Clinic DSLParser state methods (python#106376)pythongh-106368: Clean up Argument Clinic tests (python#106373)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@miss-islington@bedevere-bot@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp