NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

[3.12] GH-106330: Fix matching of empty path in`pathlib.PurePath.match()` (GH-106331)#106372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

barneygale merged 2 commits intopython:3.12frombarneygale:backport-b4efdf8-3.12

Jul 4, 2023

Merged

[3.12] GH-106330: Fix matching of empty path in`pathlib.PurePath.match()` (GH-106331)#106372

barneygale merged 2 commits intopython:3.12frombarneygale:backport-b4efdf8-3.12

Jul 4, 2023

Conversation

Copy link

Contributor

barneygale commentedJul 3, 2023•
edited by bedevere-bot
Loading

We match paths using the_lines attribute, which is derived from the path's string representation. The bug arises because an empty path's string representation is'.' (not''), which is matched by the'*' wildcard. (cherry picked from commitb4efdf8)

Issue:pathlib.PurePath.match() can incorrectly match empty path #106330

[3.12]pythonGH-106330: Fix matching of empty path in `pathlib.PurePa…

e320740

…th.match()` (pythonGH-106331)We match paths using the `_lines` attribute, which is derived from thepath's string representation. The bug arises because an empty path's stringrepresentation is `'.'` (not `''`), which is matched by the `'*'` wildcard.(cherry picked from commitb4efdf8)Co-authored-by: Barney Gale <barney.gale@gmail.com>

barneygale added the topic-pathlib label

Jul 3, 2023