NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

GH-106008: Fix refleak when peepholing`None` comparisons#106367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 2 commits intopython:mainfrombrandtbucher:to-bool-refleak

Jul 4, 2023

Merged

GH-106008: Fix refleak when peepholing`None` comparisons#106367

pablogsal merged 2 commits intopython:mainfrombrandtbucher:to-bool-refleak

Jul 4, 2023

Conversation

Copy link

Member

brandtbucher commentedJul 3, 2023•
edited by bedevere-bot
Loading

Issue:Make implicit boolean conversions explicit #106008

brandtbucher added2 commits

July 3, 2023 11:36

Fix refleak when peepholing branches on None

e05186a

blurb add

d5afb7c

brandtbucher added type-bug

An unexpected behavior, bug, or error

interpreter-core(Objects, Python, Grammar, and Parser dirs) labels

Jul 3, 2023

brandtbucher requested a review frompablogsal

July 3, 2023 18:40

brandtbucher self-assigned this

Jul 3, 2023

brandtbucher requested review frommarkshannon andiritkatriel ascode owners

July 3, 2023 18:40

bedevere-bot added the awaiting core review label

Jul 3, 2023

brandtbucher changed the title~~Fix refleak when peepholingNone comparisons~~GH-106008: Fix refleak when peepholingNone comparisons

Jul 3, 2023

bedevere-bot mentioned this pull request

Jul 3, 2023

Make implicit boolean conversions explicit#106008

Closed

pablogsal added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section label

Jul 3, 2023

Copy link

bedevere-bot commentedJul 3, 2023

🤖 New build scheduled with the buildbot fleet by@pablogsal for commitd5afb7c 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

bedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section label

Jul 3, 2023

carljm approved these changes

Jul 3, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Jul 3, 2023

pablogsal merged commite4ba71f intopython:main

Jul 4, 2023

bedevere-bot removed the awaiting merge label

Jul 4, 2023

Copy link

Member

pablogsal commentedJul 4, 2023

Thanks a lot@brandtbucher 🖤

carljm added a commit to carljm/cpython that referenced this pull request

Jul 5, 2023

Merge branch 'main' into modulelocals

4c59e51

* main: (39 commits)pythongh-102542 Remove unused bytes object and bytes slicing (python#106433)  Clarify state of CancelledError in doc (python#106453)pythongh-64595: Fix regression in file write logic in Argument Clinic (python#106449)pythongh-104683: Rename Lib/test/clinic.test as Lib/test/clinic.test.c (python#106443)  tp_flags docs: fix indentation (python#106420)pythongh-104050: Partially annotate Argument Clinic CLanguage class (python#106437)pythongh-106368: Add tests for formatting helpers in Argument Clinic (python#106415)pythongh-104050: Annotate Argument Clinic parameter permutation helpers (python#106431)pythongh-104050: Annotate toplevel functions in clinic.py (python#106435)pythongh-106320: Fix specialize.c compilation by including pycore_pylifecycle.h (python#106434)  Add some codeowners for `Tools/clinic/` (python#106430)pythongh-106217: Truncate the issue body size of `new-bugs-announce-notifier` (python#106423)pythongh-61215: Rename `wait_until_any_call` to `wait_until_any_call_with` (python#106414)pythongh-106162: array: suppress warning in test_array (python#106404)pythongh-106320: Remove _PyInterpreterState_HasFeature() (python#106425)pythonGH-106360: Support very basic superblock introspection (python#106422)pythongh-106406: Fix _Py_IsInterpreterFinalizing() in _winapi.c (python#106408)pythongh-106396: Special-case empty format spec to gen empty JoinedStr node (python#106401)pythongh-106368: Add tests for permutation helpers in Argument Clinic (python#106407)pythonGH-106008: Fix refleak when peepholing `None` comparisons (python#106367)  ...