Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-106123: Modules/_sha3 appears to no longer be necessary#106124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hauntsaninja merged 2 commits intopython:mainfromsmontanaro:main
Jun 27, 2023

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedJun 26, 2023•
edited by bedevere-bot
Loading

This is a pretty trivial PR. I'm guessingModules/_sha3 was a holdover from beforeModules/_hacl existed. Perhaps there's a valid reason for it to still exist (used on another platform?), but if so, maybe it should be described in a comment inconfigure.ac

@erlend-aasland
Copy link
Contributor

Thanks, Skip! Can you do amake regen-configure and commit the changes?

Copy link
Member

@sunmy2019sunmy2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like it was indeed removed in#103597

erlend-aasland reacted with thumbs up emoji
@miss-islington
Copy link
Contributor

Thanks@smontanaro for the PR, and@hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 27, 2023
…honGH-106124)(cherry picked from commit0345b0c)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
@bedevere-bot
Copy link

GH-106127 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 27, 2023
hauntsaninja pushed a commit that referenced this pull requestJun 27, 2023
…-106124) (#106127)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@sunmy2019sunmy2019sunmy2019 approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@smontanaro@erlend-aasland@miss-islington@bedevere-bot@hauntsaninja@sunmy2019
[8]ページ先頭
©2009-2025 Movatter.jp