Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-89812: Simplify creation of symlinks in pathlib tests.#106061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
GH-89812: Simplify creation of symlinks in pathlib tests.#106061
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Remove `PathTest.dirlink()` function. Symlinks in `PathTest.setUp()` arecreated using `os.symlink()` directly; symlinks in test functions use`Path.symlink_to()` in order to make the tests applicable to a(near-)future `AbstractPath` class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not an expert on symlink handling, but while it does make the test code slightly less concise, there appears to be a motivated reason to do so, it eliminates a workaround, and is needed for future improvements. I also couldn't spot any obvious issues in the implementation, though again, I defer to Barney and others regarding SME issues.
Thank you for the review CAM! |
…onGH-106061)Remove `PathTest.dirlink()` function. Symlinks in `PathTest.setUp()` arecreated using `os.symlink()` directly; symlinks in test functions use`Path.symlink_to()` in order to make the tests applicable to a(near-)future `AbstractPath` class.
Uh oh!
There was an error while loading.Please reload this page.
Remove
PathTest.dirlink()function. Symlinks inPathTest.setUp()are created usingos.symlink()directly; symlinks in test functions usePath.symlink_to()in order to make the tests applicable to a (near-)futureAbstractPathclass.