Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-89812: Make symlink support configurable in pathlib tests.#106060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
GH-89812: Make symlink support configurable in pathlib tests.#106060
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Adjust the pathlib tests to add a new `PathTest.can_symlink` classattribute, which allows us to enable or disable symlink support in tests.A (near-)future commit will add an `AbstractPath` class; its tests willhard-code the value to `True` or `False` depending on a stub subclass'scapabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not an expert, but the change seems reasonable, motivated and straightforward to me, and I didn't spot any obvious issues with the implementation reading through it.
Youmight want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows). |
Good idea! How do I do that? :) |
bedevere-bot commentedJun 30, 2023
🤖 New build scheduled with the buildbot fleet by@barneygale for commitf9bdd3a 🤖 If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
Uh oh!
There was an error while loading.Please reload this page.
Adjust the pathlib tests to add a new
PathTest.can_symlinkclass attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add anAbstractPathclass; its tests will hard-code the value toTrueorFalsedepending on a stub subclass's capabilities.