NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-105922: Use PyImport_AddModuleRef() function#105999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:add_module_ref

Jun 22, 2023

Merged

gh-105922: Use PyImport_AddModuleRef() function#105999

vstinner merged 1 commit intopython:mainfromvstinner:add_module_ref

Jun 22, 2023

Conversation

Copy link

Member

vstinner commentedJun 22, 2023•
edited by bedevere-bot
Loading

Replace PyImport_AddModuleObject() + Py_XNewRef() with PyImport_AddModuleRef() to get directly a strong reference.

Issue:C API: Add PyImport_AddModuleRef() function #105922

pythongh-105922: Use PyImport_AddModuleRef() function

57b2b7b

Replace PyImport_AddModuleObject() + Py_XNewRef() withPyImport_AddModuleRef() to get directly a strong reference.

vstinner requested review frombrettcannon,ericsnowcurrently,ncoghlan andwarsaw ascode owners

June 22, 2023 20:33

bedevere-bot added the awaiting core review label

Jun 22, 2023

bedevere-bot mentioned this pull request

Jun 22, 2023

C API: Add PyImport_AddModuleRef() function#105922

Closed

vstinner added the skip news label

Jun 22, 2023

Copy link

MemberAuthor

vstinner commentedJun 22, 2023

test_threading failed with a warning on the Address sanitizer CI:

test_4_daemon_threads (test.test_threading.ThreadJoinOnShutdown.test_4_daemon_threads) ... oktest_clear_threads_states_after_fork (test.test_threading.ThreadJoinOnShutdown.test_clear_threads_states_after_fork) ... oktest_reinit_tls_after_fork (test.test_threading.ThreadJoinOnShutdown.test_reinit_tls_after_fork) ... Warning -- Uncaught thread exception: AssertionErrorException in thread Thread-36 (do_fork_and_wait):Traceback (most recent call last):  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 1052, in _bootstrap_inner    self.run()  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 989, in run    self._target(*self._args, **self._kwargs)  File "/home/runner/work/cpython/cpython/Lib/test/test_threading.py", line 1173, in do_fork_and_wait    support.wait_process(pid, exitcode=50)  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2156, in wait_process    raise AssertionError(f"process {pid} is still running "AssertionError: process 21364 is still running after 300.3 secondsok