Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-105927: Avoid calling PyWeakref_GET_OBJECT()#105997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Replace PyWeakref_GET_OBJECT() with _PyWeakref_GET_REF().* _sqlite/blob.c now holds a strong reference to the blob object while calling close_blob().* _xidregistry_find_type() now holds a strong reference to registered while using it.
| PyObject *blob = PyWeakref_GetObject(weakref); | ||
| if (!Py_IsNone(blob)) { | ||
| close_blob((pysqlite_Blob *)blob); | ||
| PyObject *blob = _PyWeakref_GET_REF(weakref); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ideally, we should use public API only in the sqlite3 extension module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I hesitated to use PyWeakref_GetRef() but pysqlite_close_all_blobs() cannot report errors (return type is void), and I hesitated to use PyErr_WriteUnraisable().
Uh oh!
There was an error while loading.Please reload this page.