Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-105927: Add _PyWeakref_IS_DEAD() function#105992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:getref_dead
Jun 22, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedJun 22, 2023
edited by bedevere-bot
Loading

  • Add _PyWeakref_IS_DEAD() internal function.
  • Modify is_dead_weakref() of Modules/_weakref.c and _pysqlite_drop_unused_cursor_references() to replace PyWeakref_GET_OBJECT() with _PyWeakref_IS_DEAD().
  • Replace "int i" with "Py_ssize_t i" to iterate on cursors in _pysqlite_drop_unused_cursor_references().

* Add _PyWeakref_IS_DEAD() internal function.* Modify is_dead_weakref() of Modules/_weakref.c and  _pysqlite_drop_unused_cursor_references() to replace  PyWeakref_GET_OBJECT() with _PyWeakref_IS_DEAD().* Replace "int i" with "Py_ssize_t i" to iterate on cursors  in _pysqlite_drop_unused_cursor_references().
@vstinner
Copy link
MemberAuthor

@erlend-aasland: PR to prepare PyWeakref_GET_OBJECT() deprecation. It changes the sqlite source code :-)

@vstinnervstinner merged commitc38da1e intopython:mainJun 22, 2023
@vstinnervstinner deleted the getref_dead branchJune 22, 2023 19:56
@erlend-aasland
Copy link
Contributor

That's a nice improvement for sqlite3 :)

@vstinner
Copy link
MemberAuthor

That's a nice improvement for sqlite3 :)

You may also like PR#105997 which is closer to a real bugfix (reduce the risk of race condition thanks to the usage of a strong reference).

erlend-aasland reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@erlend-aasland@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp