NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-105927: _abc and _thread use PyWeakref_GetRef()#105961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:getref

Jun 21, 2023

Merged

gh-105927: _abc and _thread use PyWeakref_GetRef()#105961

vstinner merged 1 commit intopython:mainfromvstinner:getref

Jun 21, 2023

Conversation

Copy link

Member

vstinner commentedJun 21, 2023•
edited by bedevere-bot
Loading

Replace PyWeakref_GET_OBJECT() with PyWeakref_GetRef() and _PyWeakref_GET_REF() to hold a strong reference on the object, rather than using a borrowed reference.

Remove assert(PyWeakref_CheckRef(localweakref)) since it's already done by _PyWeakref_GET_REF().

Issue:C API: Add PyWeakref_GetRef() function #105927

pythongh-105927: _abc and _thread use PyWeakref_GetRef()

70fd112

Replace PyWeakref_GET_OBJECT() with PyWeakref_GetRef() and_PyWeakref_GET_REF() to hold a strong reference on the object, ratherthan using a borrowed reference.Remove assert(PyWeakref_CheckRef(localweakref)) since it's alreadydone by _PyWeakref_GET_REF().