NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-105922: Refactor PyRun_InteractiveOneObjectEx()#105925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:pythonrun

Jun 19, 2023

Merged

gh-105922: Refactor PyRun_InteractiveOneObjectEx()#105925

vstinner merged 1 commit intopython:mainfromvstinner:pythonrun

Jun 19, 2023

Conversation

Copy link

Member

vstinner commentedJun 19, 2023•
edited by bedevere-bot
Loading

Refactor PyRun_InteractiveOneObjectEx(), _PyRun_SimpleFileObject() and PyRun_SimpleStringFlags():

Keep a strong reference to themain module while using its dictionary (PyModule_GetDict()). Use PyImport_AddModule() with Py_XNewRef().
Declare variables closer to where they are defined.
Rename variables to use name longer than 1 character.
Add pyrun_one_parse_ast() sub-function.

Issue:C API: Add PyImport_AddModuleRef() function #105922

pythongh-105922: Refactor PyRun_InteractiveOneObjectEx()

66fb11f

Refactor PyRun_InteractiveOneObjectEx(), _PyRun_SimpleFileObject()and PyRun_SimpleStringFlags():* Keep a strong reference to the __main__ module while using its  dictionary (PyModule_GetDict()). Use PyImport_AddModule() with  Py_XNewRef().* Declare variables closer to where they are defined.* Rename variables to use name longer than 1 character.* Add pyrun_one_parse_ast() sub-function.