Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105481: generate _specializations and _specialized_instructions from bytecodes.c#105913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 9 commits intopython:mainfromiritkatriel:specialziation-data
Jun 19, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJun 19, 2023•
edited by bedevere-bot
Loading

This generates the metadata about specialised opcodes from bytecodes.c, to replace the hard coded dict in opcode.py.

There is one irregularity that I needed to special-case: BINARY_OP_INPLACE_ADD_UNICODE, which is commented out in bytecodes.c (because it has different stack effect compared to the rest of the family).

Fidget-Spinner and gvanrossum reacted with thumbs up emojiFidget-Spinner and Eclips4 reacted with rocket emoji
@iritkatrieliritkatriel requested a review froma team as acode ownerJune 19, 2023 14:01
@markshannon
Copy link
Member

markshannon commentedJun 19, 2023•
edited
Loading

We should move the optimization inBINARY_OP_INPLACE_ADD_UNICODE to tier 2, once it we have a tier 2 optimizer. It makes sense there, but not in tier 1.
For now we can just remove it. I suspectBINARY_OP_INPLACE_ADD_UNICODE is not safe for PEP 669 anyway.
#100982

@markshannon
Copy link
Member

Looks likesummarize_stats.py needs updating

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. One nit; no need to get another review if you decide to fix that. Also okay to merge as-is.

@iritkatrieliritkatriel merged commit33f0a85 intopython:mainJun 19, 2023
@iritkatrieliritkatriel deleted the specialziation-data branchJune 19, 2023 22:47
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@iritkatriel@markshannon@gvanrossum@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp