Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105879: Add support for keyword arguments to eval and exec#105885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 8 commits intopython:mainfromrtpg:exec-kwargs
May 2, 2024

Conversation

rtpg
Copy link
Contributor

@rtpgrtpg commentedJun 17, 2023•
edited by bedevere-bot
Loading

arhadthedev reacted with thumbs up emojinoamcohen97 reacted with hooray emoji
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@ghost
Copy link

ghost commentedJun 17, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for suggesting and adding this feature! I've definitely confused the ordering of these before :-) This looks good to me (although I think I still have a vague preference for keeping thesource argument positional-only)

@iritkatriel
Copy link
Member

Does this need a doc change?

@rtpg
Copy link
ContributorAuthor

rtpg commentedJul 4, 2023

@iritkatriel i believe that the docstring changes (derived from the arg clinic changes) are sufficient, as I did not see anything being explicit about positional-only-ness beyond that

@JelleZijlstraJelleZijlstra self-assigned thisMay 1, 2024
@JelleZijlstra
Copy link
Member

I fixed the (trivial) merge conflict, undid an unnecessary formatting change, and added a documentation note as@iritkatriel suggested. I'll merge the PR in a bit so we can get this change into 3.13.

rtpg reacted with thumbs up emoji

@JelleZijlstra
Copy link
Member

Thinking about it again I agree with@hauntsaninja's suggestion above that we should leave the first argument positional-only. I'll make that change.

@JelleZijlstraJelleZijlstra merged commit2770d5c intopython:mainMay 2, 2024
36 checks passed
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

@JelleZijlstraJelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@rtpg@bedevere-bot@iritkatriel@JelleZijlstra@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp