Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
GH-89812: Churnpathlib.Path test methods#105807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
barneygale merged 1 commit intopython:mainfrombarneygale:gh-89812-churn-pathlib-path-test-methodsJun 15, 2023
Merged
GH-89812: Churnpathlib.Path test methods#105807
barneygale merged 1 commit intopython:mainfrombarneygale:gh-89812-churn-pathlib-path-test-methodsJun 15, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Re-arrange `pathlib.Path` test methods in source code. No other changes.The test methods are arranged in two groups. The first group checks`stat()`, `open()`, `iterdir()`, `readlink()`, and derived methods like`exists()`, `read_text()`, `glob()` and `resolve()`. The second groupchecks all other `Path` methods. To minimise the diff I've maintained themethod order within groups where possible.This patch prepares the ground for a new `_AbstractPath` class, which willsupport methods in the first group above. By churning the test methodshere, subsequent patches will be easier to review and less likely to breakthings.
JelleZijlstra approved these changesJun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, verified the net line change is 0. The test failure seems unrelated.
Thank you! |
carljm added a commit to carljm/cpython that referenced this pull requestJun 15, 2023
* main: (57 commits)pythongh-105831: Fix NEWS blurb frompythongh-105828 (python#105833)pythongh-105820: Fix tok_mode expression buffer in file & readline tokenizer (python#105828)pythongh-105751, test_ctypes: Remove disabled tests (python#105826)pythongh-105821: Use a raw f-string in test_httpservers.py (python#105822)pythongh-105751: Remove platform usage in test_ctypes (python#105819)pythongh-105751: Reenable disable test_ctypes tests (python#105818)pythongh-105751: Remove dead code in test_ctypes (python#105817) More reorganisation of the typing docs (python#105787) Improve docs for `typing.dataclass_transform` (python#105792)pythonGH-89812: Churn `pathlib.Path` test methods (python#105807)pythongh-105800: Issue SyntaxWarning in f-strings for invalid escape sequences (python#105801)pythongh-105751: Cleanup test_ctypes imports (python#105803)pythongh-105481: add HAS_JUMP flag to opcode metadata (python#105791)pythongh-105751: test_ctypes avoids the operator module (pythonGH-105797)pythongh-105751: test_ctypes: Remove @need_symbol decorator (pythonGH-105798)pythongh-104909: Implement conditional stack effects for macros (python#105748)pythongh-75905: Remove test_xmlrpc_net: skipped since 2017 (python#105796)pythongh-105481: Fix types and a bug for pseudos (python#105788) Update DSL docs for cases generator (python#105753)pythonGH-77273: Better bytecodes for f-strings (pythonGH-6132) ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Similar to#104243
Re-arrange
pathlib.Pathtest methods in source code. No other changes.The test methods are arranged in two groups. The first group checks
stat(),open(),iterdir(),readlink(), and derived methods likeexists(),read_text(),glob()andresolve(). The second group checks all otherPathmethods. To minimise the diff I've maintained the method order within groups where possible.This patch prepares the ground for a new
_AbstractPathclass, which will support methods in the first group above. By churning the test methods here, subsequent patches will be easier to review and less likely to break things.