Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-105733: Deprecate ctypes SetPointerType() and ARRAY()#105734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
A code search on A code search on It seems like a very low number of projects will be affected by this change. cc@hugovk |
Thanks for the review@hugovk. |
| def ARRAY(typ, len): | ||
| import warnings | ||
| warnings._deprecated("ctypes.ARRAY", remove=(3, 15)) | ||
| return typ * len |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you think there's a high expected maintenance overhead or security risk here?
Per PEP 387:
If the expected maintenance overhead and security risk of the deprecated behavior is small (e.g. an old function is reimplemented in terms of a new, more general one), it can stay indefinitely (or until the situation changes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
it's not a big maintenance burden nor a securty issue, why do you ask?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I ask to see if there's a special reason forremove=(3, 15), or if it can be relaxed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What do you propose? To postpone the removal to Python 3.16?
On PyPI top 8,000 projects (at 2024-03-16), I found only 2 projects using ctypes.ARRAY. I search for regexctypes.ARRAY|\<ARRAY\> (and excluded unrelated lines).
- astroid (3.1.0)
- pwntools (4.12.0)
It's about two lines:
astroid-3.1.0.tar.gz: astroid-3.1.0/tests/brain/test_ctypes.py: ctypes.ARRAY(3, 2)pwntools-4.12.0.tar.gz: pwntools-4.12.0/pwnlib/adb/bootloader.py: imgarray = ctypes.ARRAY(img_info, self.num_images)Before the function was only deprecated with a comment:
# XXX DeprecateddefARRAY(typ,len):returntyp*len
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll propose to follow the part of PEP 387 I quoted above. Alternatively, since this does break known projects, to soft-deprecate instead.
But I plan to propose that in the beta period, right now I'm only gathering info. Thanks for the answer!
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--105734.org.readthedocs.build/