Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-67565: remove redundant C-contiguity checks#105521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 33 commits intopython:mainfromfurkanonder:issue-67565
Oct 23, 2023

Conversation

@furkanonder
Copy link
Contributor

@furkanonderfurkanonder commentedJun 8, 2023•
edited by bedevere-bot
Loading

@furkanonderfurkanonder added the performancePerformance or resource usage labelAug 5, 2023
@furkanonderfurkanonder changed the titleGH-67565: remove redundant C-contiguity check in getargs.cgh-67565: remove redundant C-contiguity check in getargs.cAug 5, 2023
@furkanonder
Copy link
ContributorAuthor

CC:@vstinner

@vstinner
Copy link
Member

cc@serhiy-storchaka

@serhiy-storchaka
Copy link
Member

It looks like the original old Stefan's patch. But currently most functions use Argument Clinic which copied a code from getargs.c, so now there are a lot ofPyBuffer_IsContiguouss in the generated code. Argument Clinic should be updated too. And there are unneeded contiguity tests in other code:#67565 (comment).

@furkanonderfurkanonder changed the titlegh-67565: remove redundant C-contiguity check in getargs.cgh-67565: remove redundant C-contiguity checksSep 10, 2023
@furkanonder
Copy link
ContributorAuthor

@ericsnowcurrently Thank you very much for your valuable feedbacks. I've made some changes. Can you review it again?

@erlend-aasland
Copy link
Contributor

@furkanonder, can you resolve the conflict, please?

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. I have minor suggestion for tests.

Since this PR adds new tests, I think that it is better to split it on two parts:

  1. Tests only. This change will be backported to 3.12 and 3.11 to avoid regressions.
  2. Other changes. So we can be sure that they do not affect the user code.

@furkanonderfurkanonder added the 3.13bugs and security fixes labelOct 17, 2023
@erlend-aasland
Copy link
Contributor

cc.@ericsnowcurrently, who requested changes.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchaka
Copy link
Member

Thank you for your contribution, Furkan. It took a long time because I wasn't sure it was completely safe. But I hope the new tests will catch the bug if we are wrong.

furkanonder reacted with heart emoji

@furkanonder
Copy link
ContributorAuthor

@serhiy-storchaka You're welcome.

aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
@furkanonderfurkanonder removed the 3.13bugs and security fixes labelDec 31, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@warsawwarsawAwaiting requested review from warsaw

@tirantiranAwaiting requested review from tiran

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

performancePerformance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@furkanonder@vstinner@serhiy-storchaka@erlend-aasland@ericsnowcurrently@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp