Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100227: Lock Around Adding Global Audit Hooks#105515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedJun 8, 2023•
edited by bedevere-bot
Loading

The risk of a race with this state is relatively low, but we play it safe anyway.

@zooba
Copy link
Member

I'd be just as happy with documenting that you need to self-synchronize when using this function. It should only be being called by embedders anyway.

But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that.

ericsnowcurrently reacted with thumbs up emoji

@ericsnowcurrently
Copy link
MemberAuthor

But this change looks okay. I'm not as familiar with our usual locking pattern though, so I'm trusting you're following that.

FWIW, we didn't have one before per-interpreter GIL. I've tried to be consistent, though, as I've been inventing the pattern. 😄

@ericsnowcurrentlyericsnowcurrently removed the request for review fromzoobaJune 8, 2023 18:32
@ericsnowcurrentlyericsnowcurrently marked this pull request as ready for reviewJune 8, 2023 18:32
@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)June 8, 2023 18:33
@ericsnowcurrentlyericsnowcurrently merged commite822a67 intopython:mainJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@ericsnowcurrently, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

@ericsnowcurrentlyericsnowcurrently deleted the audit-hooks-state-granular-lock branchJune 8, 2023 18:39
@ericsnowcurrentlyericsnowcurrently added needs backport to 3.12only security fixes and removed needs backport to 3.12only security fixes labelsJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@ericsnowcurrently, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

@ericsnowcurrentlyericsnowcurrently added needs backport to 3.12only security fixes and removed needs backport to 3.12only security fixes labelsJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@ericsnowcurrently, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

@ericsnowcurrentlyericsnowcurrently removed the needs backport to 3.12only security fixes labelJun 8, 2023
@ericsnowcurrentlyericsnowcurrently added the needs backport to 3.12only security fixes labelJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@ericsnowcurrently, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker e822a676f1f3bef6c5413e9b856db481c08ac2a5 3.12

ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull requestJun 8, 2023
The risk of a race with this state is relatively low, but we play it safe anyway.
@bedevere-bot
Copy link

GH-105525 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 8, 2023
ericsnowcurrently added a commit that referenced this pull requestJun 8, 2023
…h-105525)The risk of a race with this state is relatively low, but we play it safe anyway.(cherry picked from commite822a67)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently@zooba@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp