Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-105481: add pseudo-instructions to the cases DSL#105506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
11 commits Select commitHold shift + click to select a range
b68004f
gh-105481: add pseudo-instructions to the cases DSL
iritkatrielde0a2ff
typo
iritkatriel11b6b38
comment
iritkatriel64fe811
regen
iritkatriel0929fac
add pseudos also to the metadata table
iritkatrielae2255d
assert that opcodes are all < 512
iritkatriel096df7a
pushed, popped --> popped, pushed
iritkatriel28ca801
trailing comma
iritkatrielc91a179
fix type union
iritkatriel506eda5
add a few comments
iritkatriel7fe09fb
add assertions about metadata of pseudos
iritkatrielFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
add a few comments
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit506eda52efaed3577b6ba2d007abde99ca192044
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -818,6 +818,7 @@ def analyze_macro(self, macro: parser.Macro) -> MacroInstruction: | ||
def analyze_pseudo(self, pseudo: parser.Pseudo) -> PseudoInstruction: | ||
targets = [self.instrs[target] for target in pseudo.targets] | ||
assert targets | ||
# Make sure the targets have the same fmt | ||
fmts = list(set([t.instr_fmt for t in targets])) | ||
assert(len(fmts) == 1) | ||
return PseudoInstruction(pseudo.name, fmts[0], targets) | ||
@@ -960,8 +961,13 @@ def effect_str(effects: list[StackEffect]) -> str: | ||
case parser.Pseudo(): | ||
instr = self.pseudos[thing.name] | ||
popped = pushed = None | ||
# Calculate stack effect, and check that it's the the same | ||
# for all targets. | ||
for target in self.pseudos[thing.name].targets: | ||
gvanrossum marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
target_instr = self.instrs.get(target) | ||
# Currently target is always an instr. This could change | ||
# in the future, e.g., if we have a pseudo targetting a | ||
# macro instruction. | ||
assert target_instr | ||
iritkatriel marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
target_popped = effect_str(target_instr.input_effects) | ||
target_pushed = effect_str(target_instr.output_effects) | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.