Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105375: Improve _pickle error handling#105475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJun 7, 2023•
edited
Loading

Error handling was deferred in some cases, which could potentially lead to exceptions being overwritten.

Issue:

Error handling was deferred in some cases, which could potentially leadto exceptions being overwritten.
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedJun 7, 2023•
edited
Loading

Slightly uncertain about commita91713a, since it changes an exception message.

EDIT: I reverted it for now.

@erlend-aaslanderlend-aasland merged commit89aac6f intopython:mainJun 9, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aaslanderlend-aasland deleted the improve-pickle-error-handling branchJune 9, 2023 17:09
@miss-islington
Copy link
Contributor

Sorry@erlend-aasland, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 89aac6f6b7b3af046ec137121c90732289e79efc 3.12

@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 89aac6f6b7b3af046ec137121c90732289e79efc 3.11

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJun 9, 2023
(cherry picked from commit89aac6f)Error handling was deferred in some cases, which could potentially leadto exceptions being overwritten.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105583 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 9, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJun 9, 2023
(cherry picked from commit89aac6f)Error handling was deferred in some cases, which could potentially leadto exceptions being overwritten.Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105584 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 9, 2023
erlend-aasland added a commit that referenced this pull requestJun 9, 2023
(cherry picked from commit89aac6f)Error handling was deferred in some cases, which could potentially leadto exceptions being overwritten.
erlend-aasland added a commit that referenced this pull requestJun 9, 2023
(cherry picked from commit89aac6f)Error handling was deferred in some cases, which could potentially leadto exceptions being overwritten.
@erlend-aaslanderlend-aasland linked an issueJun 9, 2023 that may beclosed by this pull request
18 tasks
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this introduced more dangerous bugs in constructors.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestAug 27, 2023
erlend-aasland added a commit that referenced this pull requestAug 27, 2023
Yhg1s pushed a commit that referenced this pull requestAug 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions

6 participants

@erlend-aasland@miss-islington@bedevere-bot@encukou@serhiy-storchaka@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp