Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105435: Fix spurious NEWLINE token if file ends with comment without a newline#105442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 1 commit intopython:mainfrompablogsal:gh-105435
Jun 7, 2023

Conversation

@pablogsal
Copy link
Member

@pablogsalpablogsal commentedJun 7, 2023•
edited by bedevere-bot
Loading

@pablogsal
Copy link
MemberAuthor

>>> tokenize.untokenize(tokenize.generate_tokens(io.StringIO('a\n ').readline))'a\n '>>> tokenize.untokenize(tokenize.generate_tokens(io.StringIO('#').readline))'#'

Copy link
Contributor

@mgmacias95mgmacias95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@pablogsalpablogsal merged commit7279fb6 intopython:mainJun 7, 2023
@pablogsalpablogsal deleted the gh-105435 branchJune 7, 2023 12:31
@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 7, 2023
… without a newline (pythonGH-105442)(cherry picked from commit7279fb6)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-105444 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 7, 2023
pablogsal pushed a commit that referenced this pull requestJun 7, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

1 more reviewer

@mgmacias95mgmacias95mgmacias95 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal@miss-islington@bedevere-bot@mgmacias95
[8]ページ先頭
©2009-2025 Movatter.jp