Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105332: [Enum] Fix unpickling flags in edge-cases#105348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanfurman merged 2 commits intopython:mainfromsobolevn:issue-105332
Jun 8, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedJun 6, 2023•
edited
Loading

The only problem that this PR fixes is thatTypeError: unsupported operand type(s) for |: 'PxdEnum' and 'NoneType' does not happen anymore.

It does not change any difference between 3.10 and 3.11

@ethanfurmanethanfurman changed the titlegh-105332: Fix unpicklingenum.Flag with specific valuesgh-105332: [Enum] Fix unpickling flags in edge-casesJun 8, 2023
@ethanfurmanethanfurman self-assigned thisJun 8, 2023
@ethanfurmanethanfurman added type-bugAn unexpected behavior, bug, or error stdlibStandard Library Python modules in the Lib/ directory 3.11only security fixes 3.12only security fixes needs backport to 3.11only security fixes 3.13bugs and security fixes needs backport to 3.12only security fixes labelsJun 8, 2023
@ethanfurmanethanfurman merged commit4ff5690 intopython:mainJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@sobolevn and@ethanfurman, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 4ff5690e591b7d11cf11e34bf61004e2ea58ab3c 3.12

@bedevere-bot
Copy link

GH-105519 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 8, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 8, 2023
…105348)* revert enum pickling from by-name to by-value(cherry picked from commit4ff5690)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ethanfurmanethanfurman added 3.12only security fixes needs backport to 3.12only security fixes and removed 3.12only security fixes needs backport to 3.12only security fixes labelsJun 8, 2023
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 8, 2023
…105348)* revert enum pickling from by-name to by-value(cherry picked from commit4ff5690)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot
Copy link

GH-105520 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 8, 2023
@sobolevn
Copy link
MemberAuthor

@ethanfurman thanks a lot for your help! 👍

ethanfurman added a commit that referenced this pull requestJun 9, 2023
… (GH-105520)* revert enum pickling from by-name to by-value(cherry picked from commit4ff5690)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull requestJun 9, 2023
… (GH-105519)* revert enum pickling from by-name to by-value(cherry picked from commit4ff5690)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ethanfurmanethanfurmanethanfurman approved these changes

Assignees

@ethanfurmanethanfurman

Labels

3.11only security fixes3.12only security fixes3.13bugs and security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@miss-islington@bedevere-bot@ethanfurman
[8]ページ先頭
©2009-2025 Movatter.jp