Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-55664: Add warning when creating a type using a namespace dictionary with non-string keys.#105338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 16 commits intopython:mainfromfurkanonder:issue-55664
Jan 28, 2024

Conversation

@furkanonder
Copy link
Contributor

@furkanonderfurkanonder commentedJun 5, 2023•
edited
Loading

Animesh-Ghosh reacted with rocket emoji
@furkanonderfurkanonder marked this pull request as ready for reviewJune 5, 2023 21:04
@furkanonderfurkanonder changed the titleGH-55664: Add warning when creating a type using a namespace dictionary with no…GH-55664: Add warning when creating a type using a namespace dictionary with non-string keys.Jun 5, 2023
@furkanonderfurkanonder added type-featureA feature request or enhancement interpreter-core(Objects, Python, Grammar, and Parser dirs) labelsAug 6, 2023
@furkanonderfurkanonder changed the titleGH-55664: Add warning when creating a type using a namespace dictionary with non-string keys.gh-55664: Add warning when creating a type using a namespace dictionary with non-string keys.Aug 6, 2023
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

name_of_class is leaked.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchakaserhiy-storchaka merged commitf7c05d7 intopython:mainJan 28, 2024
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…ctionary with non-string keys. (pythonGH-105338)Co-authored-by: Daniel Urban <durban@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@furkanonder@serhiy-storchaka@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp