Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix reference toparse_args inoptparse.rst#105265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 4 commits intopython:mainfromkoyuki7w:doc-patch-1
Jun 28, 2023

Conversation

koyuki7w
Copy link
Contributor

@koyuki7wkoyuki7w commentedJun 3, 2023•
edited by github-actionsbot
Loading

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR.

However, this currently updates the links to point to theparse_args method oftheargparse module, when it should be pointing to theparse_args method ofthisoptparse module.

The reason we're getting warnings is because theoptparse'sparse_args doesn't yet have documentation in thisoptparse.rst file.

It does have a docstring, so that could be used as a starting point for adding it here:

defparse_args(self,args=None,values=None):

koyuki7w reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovkhugovk added the pendingThe issue will be closed if no feedback is provided labelJun 5, 2023
@koyuki7w
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@hugovk
Copy link
Member

Thank you!

koyuki7w reacted with thumbs up emoji

@hugovkhugovk merged commit18f51f9 intopython:mainJun 28, 2023
@miss-islington
Copy link
Contributor

Thanks @F3eQnxN3RriK for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-106204 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 28, 2023
@bedevere-bot
Copy link

GH-106205 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 28, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 28, 2023
…honGH-105265)(cherry picked from commit18f51f9)Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 28, 2023
…honGH-105265)(cherry picked from commit18f51f9)Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
@koyuki7wkoyuki7w deleted the doc-patch-1 branchJune 28, 2023 12:32
hugovk pushed a commit that referenced this pull requestJun 28, 2023
…-105265) (#106205)Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
hugovk pushed a commit that referenced this pull requestJun 28, 2023
…-105265) (#106204)Co-authored-by: F3eQnxN3RriK <drsuaimqjgar@gmail.com>
@AA-TurnerAA-Turner removed the pendingThe issue will be closed if no feedback is provided labelApr 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@koyuki7w@bedevere-bot@hugovk@miss-islington@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp