Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-89886: Use Autoconf quadrigraphs where appropriate#105226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedJun 2, 2023
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
ContributorAuthor

@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the% char.

@corona10
Copy link
Member

corona10 commentedJun 2, 2023
edited
Loading

Yeah yeah, I understood what you intended. I have the same issue with my vim editor.
What do you think about writing documentation for configure.ac?
Now some semantics is not intuitive to the unfamiliar user. But if the documentation exists, it would be helpful to write new things or maintain the configure.ac

@erlend-aasland
Copy link
ContributorAuthor

What do you think about writing documentation for configure.ac?

I don't think we need to maintain our own Autoconf docs; the GNU Autoconf docs are well written and full of good examples.

@corona10corona10 requested a review fromvstinnerJune 2, 2023 09:25
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The code correctly works as expected.%:@include is surprising and looks specific to autotools, whereas C uses#include. The benefit is to fix syntax highlight? I'm not convinced that it's worth it.

@corona10 are you ok with this? In my editor (Vim), this fix is very helpful, not specifically because of the highlighting, but also because it enables Vim to correctly recognise closing parentheses and brackets. This makes hacking Autoconf way easier, since I can quickly verify opening/closing brackets and parentheses using the % char.

Well, that was just my opinion. Now it's up to you. You're way more active on changing configure than me :-)

erlend-aasland and corona10 reacted with thumbs up emoji
@erlend-aasland
Copy link
ContributorAuthor

Now it's up to you. You're way more active on changing configure than me :-)

Thanks for you input. I'll abide with Dong-hee's final word on this :)

I won't repeat my arguments as to why I think this is worth it (see#105226 (comment)), but (surprise, surprise) I still would like to land this :) An alternative could be to make sure strings including# are not followed by a closing bracket (quote) on the same line, however such a PR will introduce a larger diff toconfigure.ac, and it will also introduce changes to the generatedconfigure file; I don't think that alternative is a better choice. This PR was designed tonot alter the generatedconfigure file, in order to keep the amount of churn to a minimum. IMO, it is an improvement to status quo.

Copy link
Member

@corona10corona10 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Okay, let's go.
From my conservative view it is +0.5.. but doing something is always better than doing nothing.
Someone may complain but soon adapt to a new convention.

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

Someone may complain but soon adapt to a new convention.

As I said in#105226 (comment), there is already precedent for using quadrigraphs inconfigure.ac (we already do for stuff like brackets) ;)

Thanks, both!

corona10 reacted with heart emoji

@erlend-aaslanderlend-aasland changed the titlegh-89886: Use Autoconf quadrigraphs to fix syntax highlightinggh-89886: Use Autoconf quadrigraphs where appropriateJun 7, 2023
@erlend-aaslanderlend-aasland merged commit27c68a6 intopython:mainJun 7, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@erlend-aasland, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 27c68a6d8f20090310450862c2c299bb7ba3c160 3.12

@erlend-aaslanderlend-aasland deleted the autoconf/quadrigraphs branchJune 7, 2023 07:11
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestJun 7, 2023
@bedevere-bot
Copy link

GH-105423 is a backport of this pull request to the3.12 branch.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@corona10corona10corona10 approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@erlend-aasland@corona10@miss-islington@bedevere-bot@vstinner

[8]ページ先頭

©2009-2025 Movatter.jp