NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122)#105211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericsnowcurrently merged 1 commit intopython:3.12frommiss-islington:backport-1469393-3.12

Jun 1, 2023

Merged

[3.12] gh-104614: Make Sure ob_type is Always Set Correctly by PyType_Ready() (gh-105122)#105211

ericsnowcurrently merged 1 commit intopython:3.12frommiss-islington:backport-1469393-3.12

Jun 1, 2023

Conversation

Copy link

Contributor

miss-islington commentedJun 1, 2023•
edited by bedevere-bot
Loading

When I added the relevant condition to type_ready_set_bases() ingh-103912, I had missed that the function also sets tp_base and ob_type (if necessary). That led to problems for third-party static types.

We fix that here, by making those extra operations distinct and by adjusting the condition to be more specific.
(cherry picked from commit1469393)

Co-authored-by: Eric Snowericsnowcurrently@gmail.com

Issue:Type object's ob_type does not get set when tp_bases is set before PyType_Ready #104614

pythongh-104614: Make Sure ob_type is Always Set Correctly by PyType_…

d374433

…Ready() (pythongh-105122)When I added the relevant condition to type_ready_set_bases() inpythongh-103912, I had missed that the function also sets tp_base and ob_type (if necessary).  That led to problems for third-party static types.We fix that here, by making those extra operations distinct and by adjusting the condition to be more specific.(cherry picked from commit1469393)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>