Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal#105195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 8 commits intopython:mainfromiritkatriel:immortals-doc
Jun 21, 2023

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedJun 1, 2023•
edited by github-actionsbot
Loading

@iritkatriel
Copy link
MemberAuthor

CC@eduardo-elizondo .

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@iritkatriel
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland,@JelleZijlstra: please review the changes made to this pull request.

Copy link
Member

@carljmcarljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, just a few more broken references to fix.

Sincebool.rst is such a small file I'd be tempted to also just fix in passing the two erroring references toPy_True andPy_False near the top of the file (line 9), but that's up to you; that line isn't changed in the PR otherwise.

erlend-aasland reacted with thumbs up emoji
iritkatrieland others added2 commitsJune 21, 2023 19:12
Co-authored-by: Carl Meyer <carl@oddbird.net>
@iritkatrieliritkatriel dismissedJelleZijlstra’sstale reviewJune 21, 2023 20:12

Changes made and approved by other reviewers.

@iritkatrieliritkatriel merged commita239272 intopython:mainJun 21, 2023
@miss-islington
Copy link
Contributor

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105977 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 21, 2023
…ecoming immortal (pythonGH-105195)(cherry picked from commita239272)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
bentasker pushed a commit to bentasker/cpython that referenced this pull requestJun 23, 2023
kumaraditya303 pushed a commit that referenced this pull requestJun 26, 2023
…becoming immortal (GH-105195) (#105977)gh-84436: update docs on Py_None/Py_True/Py_False/Py_Ellipsis becoming immortal (GH-105195)(cherry picked from commita239272)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatrieliritkatriel deleted the immortals-doc branchJuly 25, 2023 18:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carljmcarljmcarljm approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel@bedevere-bot@miss-islington@carljm@JelleZijlstra@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp