Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-105144: Runtime-checkable protocols: move all 'sanity checks' to_ProtocolMeta.__subclasscheck__
#105152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…ta.__subclasscheck__`
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Thanks@AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…' to `_ProtocolMeta.__subclasscheck__` (pythonGH-105152)(cherry picked from commitc05c31d)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
bedevere-bot commentedMay 31, 2023
GH-105160 is a backport of this pull request to the3.12 branch. |
We are finally here! |
[](https://renovatebot.com)This PR contains the following updates:| Package | Change | Age | Adoption | Passing | Confidence ||---|---|---|---|---|---|| [typing-extensions](https://togithub.com/python/typing_extensions)([changelog](https://togithub.com/python/typing_extensions/blob/main/CHANGELOG.md))| `==4.5.0` -> `==4.6.3` |[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|[](https://docs.renovatebot.com/merge-confidence/)|---### Release Notes<details><summary>python/typing_extensions</summary>###[`v4.6.3`](https://togithub.com/python/typing_extensions/blob/HEAD/CHANGELOG.md#Release-463-June-1-2023)[CompareSource](https://togithub.com/python/typing_extensions/compare/4.6.2...4.6.3)- Fix a regression introduced in v4.6.0 in the implementation of runtime-checkable protocols. The regression meantthat doing `class Foo(X, typing_extensions.Protocol)`, where `X` was aclass that had `abc.ABCMeta` as its metaclass, would then cause subsequent `isinstance(1, X)` calls to erroneously raise `TypeError`. Patch byAlex Waygood (backporting theCPython[https://github.com/python/cpython/pull/105152](https://togithub.com/python/cpython/pull/105152)l/105152).- Sync the repository's LICENSE file with that of CPython. `typing_extensions` is distributed under the same license as CPython itself.- Skip a problematic test on Python 3.12.0b1. The test fails on 3.12.0b1due to a bug in CPython, which will be fixed in 3.12.0b2. The `typing_extensions` test suite now passes on 3.12.0b1.###[`v4.6.2`](https://togithub.com/python/typing_extensions/blob/HEAD/CHANGELOG.md#Release-462-May-25-2023)[CompareSource](https://togithub.com/python/typing_extensions/compare/4.6.1...4.6.2)- Fix use of `@deprecated` on classes with `__new__` but no `__init__`. Patch by Jelle Zijlstra.- Fix regression in version 4.6.1 where comparing a generic classagainst aruntime-checkable protocol using `isinstance()` would cause`AttributeError` to be raised if using Python 3.7.###[`v4.6.1`](https://togithub.com/python/typing_extensions/blob/HEAD/CHANGELOG.md#Release-461-May-23-2023)[CompareSource](https://togithub.com/python/typing_extensions/compare/4.6.0...4.6.1)- Change deprecated `@runtime` to formal API `@runtime_checkable` in theerror message. Patch by Xuehai Pan.- Fix regression in 4.6.0 where attempting to define a `Protocol` thatwasgeneric over a `ParamSpec` or a `TypeVarTuple` would cause `TypeError`to be raised. Patch by Alex Waygood.###[`v4.6.0`](https://togithub.com/python/typing_extensions/blob/HEAD/CHANGELOG.md#Release-460-May-22-2023)[CompareSource](https://togithub.com/python/typing_extensions/compare/4.5.0...4.6.0)- `typing_extensions` is now documented athttps://typing-extensions.readthedocs.io/en/latest/. Patch by JelleZijlstra.- Add `typing_extensions.Buffer`, a marker class for buffer types, asproposedby PEP 688. Equivalent to `collections.abc.Buffer` in Python 3.12. Patchby Jelle Zijlstra.- Backport two CPython PRs fixing various issues with `typing.Literal`:[https://github.com/python/cpython/pull/23294](https://togithub.com/python/cpython/pull/23294)3294[https://github.com/python/cpython/pull/23383](https://togithub.com/python/cpython/pull/23383)ll/23383.Both CPython PRs wereoriginally by Yurii Karabas, and both were backported to Python >=3.9.1,but no earlier. Patch by Alex Waygood.A side effect of one of the changes is that equality comparisons of`Literal`objects will now raise a `TypeError` if one of the `Literal` objectsbeingcompared has a mutable parameter. (Using mutable parameters with`Literal` is not supported by PEP 586 or by any major static type checkers.)- `Literal` is now reimplemented on all Python versions <= 3.10.0. The`typing_extensions` version does not suffer from the bug that was fixedin[https://github.com/python/cpython/pull/29334](https://togithub.com/python/cpython/pull/29334)9334.(The CPython bugfix was backported to CPython 3.10.1 and 3.9.8, but no earlier.)- Backport [CPython PR26067](https://togithub.com/python/cpython/pull/26067) (originally by Yurii Karabas), ensuring that `isinstance()` calls on protocols raise `TypeError` when the protocol is not decorated with `@runtime_checkable`. Patch by Alex Waygood.- Backport several significant performance improvements toruntime-checkableprotocols that have been made in Python 3.12([https://github.com/python/cpython/issues/74690](https://togithub.com/python/cpython/issues/74690)es/74690for details). Patch by Alex Waygood.A side effect of one of the performance improvements is that the membersofa runtime-checkable protocol are now considered “frozen” at runtime assoon as the class has been created. Monkey-patching attributes onto aruntime-checkable protocol will still work, but will have no impact on `isinstance()` checks comparing objects to the protocol. See["What's New in Python3.12"](https://docs.python.org/3.12/whatsnew/3.12.html#typing) for more details.- `isinstance()` checks against runtime-checkable protocols now use `inspect.getattr_static()` rather than `hasattr()` to lookup whetherattributes exist(backport[https://github.com/python/cpython/pull/103034](https://togithub.com/python/cpython/pull/103034)3034). This means that descriptors and `__getattr__` methods are no longerunexpectedly evaluated during `isinstance()` checks againstruntime-checkableprotocols. However, it may also mean that some objects which used to beconsidered instances of a runtime-checkable protocol on older versionsof`typing_extensions` may no longer be considered instances of thatprotocolusing the new release, and vice versa. Most users are unlikely to beaffected by this change. Patch by Alex Waygood.- Backport the ability to define `__init__` methods on Protocol classes,achange made in Python 3.11 (originallyimplemented[https://github.com/python/cpython/pull/31628](https://togithub.com/python/cpython/pull/31628)ll/31628by Adrian Garcia Badaracco). Patch by Alex Waygood.- Speedup `isinstance(3, typing_extensions.SupportsIndex)` by >10x onPython <3.12. Patch by Alex Waygood.- Add `typing_extensions` versions of `SupportsInt`, `SupportsFloat`,`SupportsComplex`, `SupportsBytes`, `SupportsAbs` and `SupportsRound`.Thesehave the same semantics as the versions from the `typing` module, but`isinstance()` checks against the `typing_extensions` versions are >10xfaster at runtime on Python <3.12. Patch by Alex Waygood.- Add `__orig_bases__` to non-generic TypedDicts, call-based TypedDicts,andcall-based NamedTuples. Other TypedDicts and NamedTuples already had theattribute. Patch by Adrian Garcia Badaracco.- Add `typing_extensions.get_original_bases`, a backport of[`types.get_original_bases`](https://docs.python.org/3.12/library/types.html#types.get_original_bases),introduced in Python 3.12(CPython[https://github.com/python/cpython/pull/101827](https://togithub.com/python/cpython/pull/101827)l/101827,originally by James Hilton-Balfe). Patch by Alex Waygood.This function should always produce correct results when called onclasses constructed using features from `typing_extensions`. However, it mayproduce incorrect results when called on some `NamedTuple` or`TypedDict` classes that use `typing.{NamedTuple,TypedDict}` on Python <=3.11.- Constructing a call-based `TypedDict` using keyword arguments for thefieldsnow causes a `DeprecationWarning` to be emitted. This matches thebehaviour of `typing.TypedDict` on 3.11 and 3.12.- Backport the implementation of `NewType` from 3.10 (where it isimplementedas a class rather than a function). This allows user-defined `NewType`sto be pickled. Patch by Alex Waygood.- Fix tests and import on Python 3.12, where `typing.TypeVar` can nolonger be subclassed. Patch by Jelle Zijlstra.- Add `typing_extensions.TypeAliasType`, a backport of`typing.TypeAliasType` from PEP 695. Patch by Jelle Zijlstra.- Backport changes to the repr of `typing.Unpack` that were made inorder to implement [PEP 692](https://peps.python.org/pep-0692/) (backport of[https://github.com/python/cpython/pull/104048](https://togithub.com/python/cpython/pull/104048)4048).Patch by Alex Waygood.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this updateagain.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://app.renovatebot.com/dashboard#github/allenporter/flux-local).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDUuMiIsInVwZGF0ZWRJblZlciI6IjM1LjEwNS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
I've taken the opportunity here to improve our test coverage of these error messages as well -- previously, we weren't actually ever testing which
TypeError
was being raised where.typing.Protocol
and unrelatedisinstance()
checks #105144