Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use CSV-separated outputs @ get-changed-files @ CI#105151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

webknjaz
Copy link
Contributor

This is necessary because paths with whitespaces tend to crash said
action[1][2][3]. Also, we don't need to use JSON as it's harder
to parse while the value isn't used except for the emptiness check.

The change fixes [4]. It also reverts commit 4c77061.

This is necessary because paths with whitespaces tend to crash saidaction[[1]][[2]][[3]]. Also, we don't need to use JSON as it's harderto parse while the value isn't used except for the emptiness check.The change fixes [[4]][1]:https://github.com/Ana06/get-changed-files#get-all-changed-files-as-space-delimited[2]:python#103914 (comment)[3]:python#103914 (comment)[4]:python#103914 (comment)
@webknjaz
Copy link
ContributorAuthor

I've made a "demo PR" that should help verify that the fix is functional. It's here:#105153.

@webknjaz
Copy link
ContributorAuthor

I've made a "demo PR" that should help verify that the fix is functional. It's here:#105153.

UPD: it does work —https://github.com/python/cpython/actions/runs/5135145133/jobs/9240164159?pr=105153#step:5:17

cc@hugovk

@webknjazwebknjaz requested a review fromhugovkJune 4, 2023 21:16
@webknjaz
Copy link
ContributorAuthor

@hugovk I think this needsskip issue andskip news too.

hugovk reacted with thumbs up emoji

webknjazand others added2 commitsJune 5, 2023 23:22
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@hugovkhugovk merged commiteaa6702 intopython:mainJun 21, 2023
webknjaz added a commit to webknjaz/cpython that referenced this pull requestJul 22, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>(cherry picked from commiteaa6702)
webknjaz added a commit to webknjaz/cpython that referenced this pull requestJul 22, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>(cherry picked from commiteaa6702)
ambv pushed a commit that referenced this pull requestJul 23, 2023
…) (#107043)Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>.(cherry picked from commit88d14da)(cherry picked from commiteaa6702)
ambv pushed a commit that referenced this pull requestJul 23, 2023
…) (#107042)Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>(cherry picked from commit88d14da)(cherry picked from commiteaa6702)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@webknjaz@hugovk@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp