Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1.#105129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

ned-deily
Copy link
Member

@ned-deilyned-deily commentedMay 31, 2023
edited by bedevere-bot
Loading

@ned-deilyned-deily added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsMay 31, 2023
@ned-deilyned-deily changed the titleUpdate multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.gh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.May 31, 2023
@ned-deilyned-deily changed the titlegh-103142: Update multissltest helper to test with OpenSSL 1.1.1u, 3.0.9, and 3.1.1.gh-103142: Update error codes, multissltests, and CI workflows for OpenSSL 1.1.1u, 3.0.9, and 3.1.1.May 31, 2023
@ned-deilyned-deily requested review fromgpshead andambvMay 31, 2023 19:48
@gpshead
Copy link
Member

There are PCbuild/ and .azure-pipelines/ references that also need updating (see my draft#105174 which I was just basing off of what I blindly did for the previous update in#101727). But lets go forward with your PR here just adding those bits. I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

@gpshead
Copy link
Member

some windows versions may need to wait on someone uploading an openssl-bin-1.1.1u artifact somewhere? based on#101727 comments@zooba did that last time.

@gpsheadgpshead requested a review fromzoobaMay 31, 2023 22:22
@zooba
Copy link
Member

I've posted the binaries for Windows. They are codesigned, so have to be done by someone with release team access.

I don't think I ever looked at that make_ssl_data.py generated .h file of string/constant definitions.

I thought there was an open issue/PR to replace this file? As we should have access to OpenSSL's copies of this data. Guess it isn't merged yet...

@gpshead
Copy link
Member

I updated my PR#105174 to have the additional bits that this touched plus a tweak to the _ssl_data .h file regeneration. If CI and buildbots are happy with it, I'll merge mine and generate the backport PRs.

@gpsheadgpshead marked this pull request as draftJune 1, 2023 03:32
@ned-deily
Copy link
MemberAuthor

Closed in favor of#105174

@gpshead
Copy link
Member

woo, thanks Ned! (we were both considering this, when I created my PR I hadn't yet looked to see if someone else had taken this on. No worries from my end about the duplicate work collision, it's good to have eyeballs on the issue).

@ned-deilyned-deily deleted the gh-103142-multissltests branchJune 6, 2023 18:49
@ambvambv removed needs backport to 3.8 needs backport to 3.9only security fixes needs backport to 3.10only security fixes needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsNov 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

@ambvambvAwaiting requested review from ambv

@zoobazoobaAwaiting requested review from zooba

@picnixzpicnixzAwaiting requested review from picnixzpicnixz will be requested when the pull request is marked ready for reviewpicnixz is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

Assignees
No one assigned
Projects
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@ned-deily@gpshead@zooba@ambv@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp