Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-105020: Share tp_bases and tp_mro Between Interpreters For All Static Builtin Types#105115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
7c3e588 Make tp_bases immortal for static builtin types.
ericsnowcurrentlyff411b2 Add _Py_ClearImmortal().
ericsnowcurrently354ff5f Drop PyInterpreterState.types.builtins[i].tp_bases.
ericsnowcurrently5be53f4 Make sure tp_bases is a tuple.
ericsnowcurrentlybf1578e Make tp_mro immortal for static builtin types.
ericsnowcurrentlyf4a5da1 Update a TODO comment.
ericsnowcurrentlye054bbe Add a test to avoid more regressions.
ericsnowcurrently78c7d0e Add a NEWS entry.
ericsnowcurrentlyFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
Add a NEWS entry.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit78c7d0ec4fcb732efb7cf7dc5aac08d7c6a8be7e
There are no files selected for viewing
3 changes: 3 additions & 0 deletionsMisc/NEWS.d/next/C API/2023-05-30-17-45-32.gh-issue-105115.iRho1K.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ``PyTypeObject.tp_bases`` (and ``tp_mro``) for builtin static types are now | ||
| shared by all interpreters, whereas in 3.12-beta1 they were stored on | ||
| ``PyInterpreterState``. Also note that now the tuples are immortal objects. |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.