NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

[3.12] GH-105113: Improve performance of`pathlib.PurePath.match()`#105114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

barneygale merged 1 commit intopython:3.12frombarneygale:gh-105113-3.12-match-perf

May 31, 2023

Merged

[3.12] GH-105113: Improve performance of`pathlib.PurePath.match()`#105114

barneygale merged 1 commit intopython:3.12frombarneygale:gh-105113-3.12-match-perf

May 31, 2023

Conversation

Copy link

Contributor

barneygale commentedMay 30, 2023•
edited
Loading

We now compile anre.Pattern object for the entire pattern. This is made more difficult byfnmatch not treating directory separators as special when evaluating wildcards (*,?, etc), and so we arrange the path parts onto separatelines in a string, and ensure we don't setre.DOTALL.

Partial backport of#101398 (excludes support for** wildcards).

Issue:Improve performance ofpathlib.PurePath.match() #105113

📚 Documentation preview 📚:https://cpython-previews--105114.org.readthedocs.build/

pythonGH-105113: Improve performance ofpathlib.PurePath.match()

b100cef

We now compile a `re.Pattern` object for the entire pattern. This is mademore difficult by `fnmatch` not treating directory separators as specialwhen evaluating wildcards (`*`, `?`, etc), and so we arrange the path partsonto separate *lines* in a string, and ensure we don't set `re.DOTALL`.Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

barneygale added performance

Performance or resource usage

topic-pathlib labels

May 30, 2023

barneygale requested a review fromzooba

May 30, 2023 20:30