Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: Temporarily skip paths with spaces to avoid error#105110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 3 commits intopython:mainfromhugovk:ci-workaround-path-spaces-error
May 30, 2023

Conversation

hugovk
Copy link
Member

PRs like these:

HaveNEWS files in subdirectories containing spaces:

  • Misc/NEWS.d/next/C API/2023-05-30-10-15-13.gh-issue-105071.dPtp7c.rst
  • Misc/NEWS.d/next/C API/2023-05-30-19-11-09.gh-issue-105107.YQwMnm.rst

But thehttps://github.com/Ana06/get-changed-files action (added in#103914) fails for such files with:

Error: One of your files includes a space. Consider using a different output format or removing spaces from your filenames. Please submit an issue on this action's GitHub repo.

We ran into this before and worked around it in#103019 by skippingMisc and its subdirs.

Let's do something similar here, by replacingMisc with a list of its subdirs that are absent a space.

See alsopython/core-workflow#186 to rename theC API andCore and Builtins directories toC-API andCore-and-Builtins to avoid this altogether.

gpshead reacted with thumbs up emoji
@hugovk
Copy link
MemberAuthor

hugovk commentedMay 30, 2023•
edited
Loading

✅ No error with a dummy file atMisc/NEWS.d/next/C API/2023-05-30-21-34-29.gh-issue-105107.1mmbfA.rst (05cd028):

Run Ana06/get-changed-files@v2.2.0Base commit: 457[1](https://github.com/python/cpython/actions/runs/5125091879/jobs/9217804839#step:5:1)eedca2f70768ddc4a2fd4fba2ae11b4c8037Head commit: 05cd028fd4c56e3173b134b10dc947c3af471d82All: Added: Modified: Removed: Renamed: Added or modified: Added, modified or renamed:

https://github.com/python/cpython/actions/runs/5125091879/jobs/9217804839

@hugovkhugovk marked this pull request as ready for reviewMay 30, 2023 19:06
@hugovkhugovk merged commit4c77061 intopython:mainMay 30, 2023
@hugovkhugovk deleted the ci-workaround-path-spaces-error branchMay 30, 2023 20:01
carljm added a commit to carljm/cpython that referenced this pull requestMay 30, 2023
* main:  CI: Temporarily skip paths with spaces to avoid error (python#105110)pythongh-105071: add missing versionadded directive (python#105097)pythongh-80064: Fix is_valid_wide_char() return type (python#105099)  Small speedup for dataclass __eq__ and __repr__ (python#104904)pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
@vstinner
Copy link
Member

But thehttps://github.com/Ana06/get-changed-files action (added in#103914) fails for such files with

Maybe you should report the bug there?

@hugovk
Copy link
MemberAuthor

It's a feature:https://github.com/Ana06/get-changed-files#usage says the default behaviour is to return files separated by spaces (format: 'space-delimited'), and will fail if any files contain spaces. They suggest using one of the other formats in such case (CSV, JSON).

(Let's continue discussion in#103914).

webknjaz added a commit to webknjaz/cpython that referenced this pull requestMay 31, 2023
@webknjaz
Copy link
Contributor

@vstinner I've just submitted a proper fix:#105151

hugovk pushed a commit to hugovk/cpython that referenced this pull requestJun 1, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull requestJun 1, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carljmcarljmcarljm approved these changes

@gpsheadgpsheadgpshead approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@hugovk@vstinner@webknjaz@carljm@gpshead@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp