Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-102251: Explicitly free state for test modules with state in test_import#105085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 8 commits intopython:mainfromsunmy2019:gh-102251-2
May 31, 2023

Conversation

sunmy2019
Copy link
Member

@sunmy2019sunmy2019 commentedMay 30, 2023•
edited by bedevere-bot
Loading

The module state is not cleared in the clean-up functions. This PR adds one clean-up function for it.

This fixes the second issue mentioned in#103879 (comment)

@erlend-aasland
Copy link
Contributor

Can you update the PR title to reflect the actual change?

@sunmy2019sunmy2019 changed the titlegh-102251: Fix ref leaks intest_importgh-102251: Add clean-up function for_testsinglephase_with_stateMay 30, 2023
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@erlend-aaslanderlend-aasland added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 30, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit26a9ede 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 30, 2023
@brettcannonbrettcannon removed their request for reviewMay 30, 2023 19:19
@erlend-aaslanderlend-aasland changed the titlegh-102251: Add clean-up function for_testsinglephase_with_stategh-102251: Explicitly free state for test modules with state in test_importMay 31, 2023
@erlend-aasland
Copy link
Contributor

Approved by Eric in#104796 (review), as part of a larger PR.

@erlend-aaslanderlend-aasland merged commita99b9d9 intopython:mainMay 31, 2023
@miss-islington
Copy link
Contributor

Thanks@sunmy2019 for the PR, and@erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 31, 2023
… test_import (pythonGH-105085)(cherry picked from commita99b9d9)Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105170 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 31, 2023
erlend-aasland added a commit that referenced this pull requestMay 31, 2023
…n test_import (GH-105085) (#105170)(cherry picked from commita99b9d9)Co-authored-by: sunmy2019 <59365878+sunmy2019@users.noreply.github.com>Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
sunmy2019 added a commit to sunmy2019/cpython that referenced this pull requestJun 1, 2023
@sunmy2019sunmy2019 deleted the gh-102251-2 branchJune 23, 2023 09:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@encukouencukouAwaiting requested review from encukou

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sunmy2019@erlend-aasland@bedevere-bot@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp